owncloud-archive / news

:newspaper: News app for ownCloud
GNU Affero General Public License v3.0
290 stars 106 forks source link

Importing two folders with the same name from an OPML file should merge their feeds #962

Closed kuba-orlik closed 8 years ago

kuba-orlik commented 8 years ago

IMPORTANT

I've imported OPML data from my feedly account and all of the feeds have been successfully imported. Unfortunately the app does not fetch any articles for any of the feeds (the unread list is consistently empty). I've ensured that the cron task is set up properly and I even tried running the cron.php and updater.php script manually, but no articles are fetched :(

Steps to Reproduce

Explain what you did to encounter the issue

  1. Import OPML file to a freshly installed News app
  2. Wait few hours
  3. No articles are fetched

    System Information

    • News app version: 8.1.0
    • ownCloud version: 9.0.0
    • PHP version: 5.6-apache
    • Database and version: SQLlite
    • Browser and version: all browsers
    • Distribution and version: Ubuntu 14.04.3 LTS

      Contents of owncloud/data/owncloud.log

No new entries in log after running cron task

Contents of Browser Error Console

Doesn't apply

BernhardPosselt commented 8 years ago

Works for me, how did configure the cron? Also what happens if you run the cron manually

sudo -u www-data php -f owncloud/cron.php  # may differ from www-data depending on distro

and can you paste your ini in owncloud/data/news/config/config.ini

BernhardPosselt commented 8 years ago

I've added a few more debugging tips here https://github.com/owncloud/news#feeds-are-not-updated

kuba-orlik commented 8 years ago

I've performed all these checks. The updater script is executed, but feeds are not refreshed. What other things should I look into?

BernhardPosselt commented 8 years ago

Can you paste your config.ini?

BernhardPosselt commented 8 years ago

Also can you curl the added feed from your console?

BernhardPosselt commented 8 years ago

Any news?

kuba-orlik commented 8 years ago

Hi, I just realized the issue was somewhere else - when importing the feeds from the OPML file, the app imported only the folders, without any feeds, without an error message - I assumed the feeds will show up once there are some new articles in them. My bad for not noticing that!

The error while importing the OPML file was due to there being two folders of that same name.

BernhardPosselt commented 8 years ago

two folders in the opml use the same name?

kuba-orlik commented 8 years ago

Yes, I exported it from Feedly. Apparently Feedly allows for two folders to have the same name.

I've noticed an additional problem with the OPML import - if the OPML contains a folder bearing a name of an already existing one, the import will fail.

BernhardPosselt commented 8 years ago

Ok, should be merged then :)

BernhardPosselt commented 8 years ago

Should be fixed in master now, can you test?

kuba-orlik commented 8 years ago

I removed the apps/news directory, downloaded the release tar.gz of the 8.3.0 version and tried the opml file on a new account, and the issue still persists. One of the server's responses while importing is

`409: Can not add folder: Exists already`