Closed ScharfViktor closed 4 months ago
Are there gonna be loadtests as part of the release?
Are there gonna be loadtests as part of the release?
yes, I want to do it
Are there gonna be loadtests as part of the release?
yes, I want to do it
Please test 5.0.0-beta.1 with
and compare the outcome.
@mmattel @butonic This https://doc.owncloud.com/ocis/next/deployment/services/s-list/proxy.html#automatic-role-assignments needs an update because of owncloud/client#7215
Bugfix cs3org/reva#4278: Disable DEPTH infinity in PROPFIND iOS Testing required. @jesmrec
Bugfix cs3org/reva#4318: Do not allow moves between shares needs testing in all clients, could cause problems, how does oc10 handle it @HanaGemela (desktop)
Bugfix cs3org/reva#4302: Fix checking of filename length Should be fixed now, needs confirmation on Desktop (deep path) @saw-jan
Bugfix cs3org/reva#4140: Fix missing etag in shares jail @Salipa-Gurung (desktop)
Bugfix cs3org/reva#4193: Fix overwrite a file with an empty file @Salipa-Gurung (desktop)
Bugfix cs3org/reva#4134: Fix share jail this https://github.com/owncloud/ocis/issues/7118 should be fixed now @Salipa-Gurung (desktop)
Bugfix cs3org/reva#4341: Fix spaceID in meta endpoint response fix already confirmed by Android and @jesmrec
Bugfix cs3org/reva#4291: Release lock when expired check if the etag changes during unlocking
Enhancement cs3org/reva#4344: Add url extension to mime type list please test in all clients on all OSSes @saw-jan (desktop)
Enhancement cs3org/reva#3926: Service Accounts IMPORTANT for all setups: ENABLE Service accounts Added Config variable: OCIS_SERVICE_ACCOUNT_ID = random UUID OCIS_SERVICE_ACCOUNT_SECRET= random string https://doc.owncloud.com/ocis/next/deployment/services/env-vars-special-scope.html Reason for the major version bump.
- Bugfix https://github.com/cs3org/reva/pull/4134: Fix share jail this https://github.com/owncloud/ocis/issues/7118 should be fixed now
fix confirmed in desktop client (5.2.0) https://github.com/owncloud/ocis/issues/7118#issuecomment-1859692962
- Enhancement https://github.com/cs3org/reva/pull/4344: Add url extension to mime type list please test in all clients on all OSSes
Ubuntu22.04 (desktop-client 5.2.0):
.url
files get syncedWindows 11:
.url
files get synced - extension is not visible (expected)MacOs: @HanaGemela Could you do it in mac?
@ScharfViktor Any other particular things (or OS) to test here?
Ubuntu22.04 (desktop-client 5.2.0):
.url
files get synced- no application to open it
Please open client docs issue. We should document this Ubuntu limitation and possible workarounds.
- Bugfix cs3org/reva#4302: Fix checking of filename length Should be fixed now, needs confirmation on Desktop (deep path)
File is able to sync to the server :heavy_check_mark:
File path: /Деснол/Разработка регламентов/Управление пользователями ИТ инфраструктуры компании/2023-05-15 Управление пользователями ИТ инфраструктуры компании.docx
Characters: 152
Bytes: 275
23-12-18 17:24:46:661 [ info sync.httplogger ]: "e4969f87-648d-48a7-8476-a57b161bd067: Request: POST https://192.168.56.1:9200/dav/spaces/14e8cce0-4e36-414d-82e4-b3f0dd049863$56a9c34d-65da-4386-bb3c-89d2d441e0f5 Header: { X-OC-Mtime: 1702899112, Content-Type: application/offset+octet-stream, Content-Length: 13, Upload-Offset: 0, Tus-Resumable: 1.0.0, Upload-Metadata: filename L9CU0LXRgdC90L7Quy/QoNCw0LfRgNCw0LHQvtGC0LrQsCDRgNC10LPQu9Cw0LzQtdC90YLQvtCyL9Cj0L/RgNCw0LLQu9C10L3QuNC1INC/0L7Qu9GM0LfQvtCy0LDRgtC10LvRj9C80Lgg0JjQoiDQuNC90YTRgNCw0YHRgtGA0YPQutGC0YPRgNGLINC60L7QvNC/0LDQvdC40LgvMjAyMy0wNS0xNSDQo9C/0YDQsNCy0LvQtdC90LjQtSDQv9C+0LvRjNC30L7QstCw0YLQtdC70Y/QvNC4INCY0KIg0LjQvdGE0YDQsNGB0YLRgNGD0LrRgtGD0YDRiyDQutC+0LzQv9Cw0L3QuNC4LmRvY3g=,checksum U0hBMSBlNWRkODU1YzliN2E4NDI0NTNiYTY1ZGIxNmY5OWFjMzEwNDg2M2E2,mtime MTcwMjg5OTExMg==, Upload-Length: 13, Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Linux) mirall/5.2.0.12726 (ownCloud, ubuntu-6.2.0-39-generic ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Accept-Language: en_US, X-Request-ID: e4969f87-648d-48a7-8476-a57b161bd067, Original-Request-ID: e4969f87-648d-48a7-8476-a57b161bd067, } Data: [13 bytes of application/offset+octet-stream data]"
23-12-18 17:24:47:037 [ info sync.httplogger ]: "e4969f87-648d-48a7-8476-a57b161bd067: Response: POST 201 (375ms) https://192.168.56.1:9200/dav/spaces/14e8cce0-4e36-414d-82e4-b3f0dd049863$56a9c34d-65da-4386-bb3c-89d2d441e0f5 Header: { Access-Control-Allow-Headers: Tus-Resumable, Upload-Length, Upload-Metadata, If-Match, Access-Control-Allow-Origin: *, Access-Control-Expose-Headers: Tus-Resumable, Upload-Offset, Location, Content-Length: 0, Content-Security-Policy: default-src 'none';, Content-Type: application/vnd.openxmlformats-officedocument.wordprocessingml.document, Date: Mon, 18 Dec 2023 11:39:47 GMT, Etag: \"f4c75fd8272dffa3b71be8da0ea033fd\", Last-Modified: Mon, 18 Dec 2023 11:31:52 +0000, Location: https://192.168.56.1:9200/data/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZXZhIiwiZXhwIjoxNzAyOTg1OTg2LCJpYXQiOjE3MDI4OTk1ODYsInRhcmdldCI6Imh0dHA6Ly9sb2NhbGhvc3Q6OTE1OC9kYXRhL3R1cy9iMDVmZTk3MS05MjkwLTRiMDAtYWYxYS00YzM5M2M3ODJhYjIifQ.SUjjppqVUBL9fdCuNxn5A1hE8O6djDMalB_gZjLdvds, Oc-Etag: \"f4c75fd8272dffa3b71be8da0ea033fd\", Oc-Fileid: 14e8cce0-4e36-414d-82e4-b3f0dd049863$56a9c34d-65da-4386-bb3c-89d2d441e0f5!0505da5c-5802-4b7a-93ef-c26e6407d2a9, Oc-Perm: RDNVWZP, Tus-Extension: creation,creation-with-upload,checksum,expiration, Tus-Resumable: 1.0.0, Upload-Expires: 1702985986, Upload-Offset: 13, Vary: Origin, X-Content-Type-Options: nosniff, X-Download-Options: noopen, X-Frame-Options: SAMEORIGIN, X-Permitted-Cross-Domain-Policies: none, X-Request-Id: e4969f87-648d-48a7-8476-a57b161bd067, X-Robots-Tag: none, X-Xss-Protection: 1; mode=block, } Data: []"
- Bugfix https://github.com/cs3org/reva/pull/4193: Fix overwrite a file with an empty file
- Bugfix https://github.com/cs3org/reva/pull/4140: Fix missing etag in shares jail
desktop client can see the etag in the empty shares jail.
23-12-19 01:45:48:657 [ info sync.httplogger ]: "7373858b-f79e-4fa6-8a82-662f04404214: Request: GET https://192.168.56.1:9200/graph/v1.0/me/drives Header: { Authorization: Bearer [redacted], User-Agent: Mozilla/5.0 (Windows) mirall/5.2.0.12726 (ownCloud, windows-10.0.19045 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Accept-Language: en_US, X-Request-ID: 7373858b-f79e-4fa6-8a82-662f04404214, Original-Request-ID: 7373858b-f79e-4fa6-8a82-662f04404214, } Data: []"
23-12-19 01:45:48:672 [ info sync.httplogger ]: "7373858b-f79e-4fa6-8a82-662f04404214: Response: GET 200 (14ms) https://192.168.56.1:9200/graph/v1.0/me/drives Header: { Content-Length: 1246, Content-Security-Policy: frame-ancestors 'none', Content-Type: application/json, Date: Tue, 19 Dec 2023 09:45:48 GMT, Vary: Origin, X-Content-Type-Options: nosniff, X-Frame-Options: DENY, X-Graph-Version: 5.0.0-beta.1, X-Request-Id: 7373858b-f79e-4fa6-8a82-662f04404214, } Data: [{\"value\":[{\"driveAlias\":\"personal/admin\",\"driveType\":\"personal\",\"id\":\"62b9dcef-7d2b-4aa8-87a3-d632c394e8c7$859d6bd8-9543-4b28-97c7-c45c3f86de3a\",\"lastModifiedDateTime\":\"2023-12-19T08:53:06.89559402Z\",\"name\":\"Admin\",\"owner\":{\"user\":{\"displayName\":\"\",\"id\":\"859d6bd8-9543-4b28-97c7-c45c3f86de3a\"}},\"quota\":{\"remaining\":54950137856,\"state\":\"normal\",\"total\":0,\"used\":11107},\"root\":{\"eTag\":\"\\\"974827309a4ac5369c0079f270b98651\\\"\",\"id\":\"62b9dcef-7d2b-4aa8-87a3-d632c394e8c7$859d6bd8-9543-4b28-97c7-c45c3f86de3a\",\"webDavUrl\":\"https://192.168.56.1:9200/dav/spaces/62b9dcef-7d2b-4aa8-87a3-d632c394e8c7$859d6bd8-9543-4b28-97c7-c45c3f86de3a\"},\"webUrl\":\"https://192.168.56.1:9200/f/62b9dcef-7d2b-4aa8-87a3-d632c394e8c7$859d6bd8-9543-4b28-97c7-c45c3f86de3a\"},{\"driveAlias\":\"virtual/shares\",\"driveType\":\"virtual\",\"id\":\"a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668\",\"name\":\"Shares\",\"root\":{\"eTag\":\"DECAFC00FEE\",\"id\":\"a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668\",\"webDavUrl\":\"https://192.168.56.1:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668\"},\"webUrl\":\"https://192.168.56.1:9200/f/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668\"}]}\n]"
Bugfix https://github.com/cs3org/reva/pull/4278: Disable DEPTH infinity in PROPFIND
Enhancement https://github.com/cs3org/reva/pull/3926: Service Accounts IMPORTANT for all setups: ENABLE Service accounts Added Config variable: OCIS_SERVICE_ACCOUNT_ID = random UUID OCIS_SERVICE_ACCOUNT_SECRET= random string https://doc.owncloud.com/ocis/next/deployment/services/env-vars-special-scope.html Reason for the major version bump.
(desktop) GUI automated tests can pass with 5.0.0-beta.1
. If it can be considered as confirmation.
Build: https://drone.owncloud.com/owncloud/client/17342
GUI test cases: https://cache.owncloud.com/public/owncloud/client/17342/ocis/guiReportUpload/index.html
CC @HanaGemela
- Bugfix https://github.com/cs3org/reva/pull/4318: Do not allow moves between shares needs testing in all clients, could cause problems, how does oc10 handle it
(desktop):
oc10: allows move between shares
Compare with “read only” target share.
ocis - 5.0.0-rc.1
and 5.0.0-rc.2
value | 4.0.0. | 5.0.0-rc.1 | 5.0.0-rc.2 |
---|---|---|---|
koko-platform-020-navigate-file-tree-ramping-k6.js | |||
http_req_duration(95) | 117.48ms | 122.8ms | |
http_req_failed | 0.00% | 0.00% | |
http_req_waiting(95) | 117.36ms | 122.7ms | |
koko-platform-040-create-upload-rename-delete-folder-and-file-ramping-k6.js | |||
http_req_duration(95) | 6.91s | 6.91s | |
http_req_failed | 0.01% | 0.00% | |
http_req_waiting(95) | 516.65ms | 531.58ms | |
koko-platform-050-download-ramping-k6.js | |||
http_req_duration(95) | 15.42s | 16.47s | |
http_req_failed | 1.20% | 0.02% | |
http_req_waiting(95) | 177.81ms | 163.66ms | |
koko-platform-070-user-group-search-ramping-k6.js | |||
http_req_duration(95) | 72.68ms | 85.01ms | |
http_req_failed | 0.00% | 0.00% | |
http_req_waiting(95) | 72.59ms | 84.93ms | |
koko-platform-080-create-space-ramping-k6.js | |||
http_req_duration(95) | 74.11ms | 152.47ms | 88.22ms |
http_req_failed | 0.00% | 80.44% | 0.00% |
http_req_waiting(95) | 74ms | 75.17ms | 88.14ms |
koko-platform-090-create-remove-group-share-ramping-k6.js | |||
http_req_duration(95) | 157.05ms | 3.9s | 125.76ms |
http_req_failed | 0.00% | 0.00% | 0.00% |
http_req_waiting(95) | 156.96ms | 3.9s | 125.66m |
koko-platform-100-add-remove-tag-ramping-k6.js | |||
http_req_duration(95) | 70ms | 97.08ms | |
http_req_failed | 0.02% | 0.01% | |
http_req_waiting(95) | 69.93ms | 97ms | |
koko-platform-110-sync-client-ramping-k6.js | |||
http_req_duration(95) | 74.15ms | 79.17ms | |
http_req_failed | 0.00% | 0.00% | |
http_req_waiting(95) | 74.03ms | 79.06ms |
how to run ocis 5.0.0: OCIS_CACHE_STORE=redis OCIS_CACHE_STORE_NODES=localhost:6379 OCIS_INSECURE=true PROXY_ENABLE_BASIC_AUTH=true ocis/bin/ocis server
✗ client -> application.createDrive - status
↳ 17% — ✓ 2317 / ✗ 11180
✗ client -> drive.deactivateDrive - status
↳ 17% — ✓ 2317 / ✗ 11180
✗ client -> drive.deleteDrive - status
↳ 17% — ✓ 2317 / ✗ 11180
koko-platform-070-user-group-search-ramping-k6.js
increased from 157.05ms
to 3.9s
iOS: iOS does the depth infinity check correctly, discovering the whole structure (checked over a deep structure) ✅ Android: No depth infinity in Android yet :heavy_minus_sign:
iOS: iOS app does not allow it, showing the following error: ✅
Room for improvement: operation could be prevented to items in the share list (create issue)
Android: Move operation is not allowed in oCIS' shares for Android yet :heavy_minus_sign:
iOS: Fixed, available 12.1+ ✅ Android: Fixed, available 4.2+ ✅
iOS: .url files not detected as straigth-openable. Needs Open In
:heavy_minus_sign:
Android: .url files not detected as straigth-openable. Needs Open In
:heavy_minus_sign:
Affects the automatic acceptance of shares. Such feature tested in both mobile clients
iOS: ✅ Android: ✅ (only list)
Android version: current stable 4.1.1
Regression test: https://github.com/owncloud/QA/blob/master/Mobile/Backend/oCIS/Android%20vs%205.0.0.md Auto tests: https://reports.cucumber.io/reports/3ea6e8b5-b71b-4586-80b5-f04f7afadc58
NOTE: only tests cases with backend involved have been executed. Tests cases that only involves mobile client have been skipped for this execution
iOS version: incoming 12.1
Regression test: https://github.com/owncloud/QA/blob/master/Mobile/Backend/oCIS/iOS%20vs%205.0.0.md Auto tests: https://reports.cucumber.io/reports/e14bef9f-bca4-4e85-b561-7e4b3e5fb6ff
NOTE: As iOS app is going to release very soon, the incoming 12.1 was used to test the new server version. For that reason, not all the test cases or reports are relevant for oCIS releases, but for iOS release.
/meta endpoint is returning a 500 for shares: That breaks deeplinks (Android) and magiclinks (iOS) over shared items. Could be blocking and affecting mobile clients
POST request to create link with incorrect password returns 400 instead of 403: 400 (even 403) is not the correct response to an "incorrect password" error.
(Improvement) Support in mobile apps to .docxf
files (only in client side)
https://github.com/owncloud/android/issues/4267 https://github.com/owncloud/ios-app/issues/1310
/meta
endpoint does not allow to open links that points to shared files/folders. I don't know how relevant is such scenario fue users, anyway 500
errors are always bad to receive. Should be fixed.Compare with “read only” target share.
(read-only share) Same behavior both in oc10 and ocis.
Since ocis doesn't allow move between shares, I wonder if the follwoing behavior is correct (I am expecting that it would behave same like with read-only share - file is reverted to it's original location):
ocis-5.0.0-beta.1: move is not possible (file is not synced - blacklisted) (https://github.com/owncloud/ocis/issues/7940#issuecomment-1864324833)
CC @michaelstingl
e2e tests 5.0.0 beta-2
against wopi:
note: failed test after re-run is green
e2e tests 5.0.0 beta-2
against traefik:
note: failed test after re-run is green
e2e tests 5.0.0 beta-2
against s3:
e2e tests 5.0.0 beta-2
against ldap:
e2e tests 5.0.0 beta-2
against local storage: all the tests are passing
smoke test against ldap:
cn=admin,dc=owncloud,dc=com
, password: admin
)
user1
group1
user1
to group1
philosophy-haters
groupmarie
userrichard
useruser1
and group group1
still existuser1
can log inphilosophy-haters
and user marie
doesn't existrichard
user still disabled and cannot log inuser2
group2
user2
to group group1
and group2
user2
can log ineinstein
user
and by group
user1
, user2
, einstein
physics-lovers
, group1
, group2
, einstein
, user1
, user2
, richard
einstein
userType as member
einstein
quotaNote: Admin cannot manage user quota using ldap https://github.com/owncloud/ocis/issues/8059
[x] Spreadsheet opd
[x] Document
[x] Presentation
[x] Spreadsheet
[x] Document
[x] Presentation
- Bugfix cs3org/reva#4318: Do not allow moves between shares needs testing in all clients, could cause problems, how does oc10 handle it @HanaGemela (desktop)
Inconsistency found:
5.0.0-beta.2
We have currently
and
- Enhancement Add url extension to mime-type list cs3org/reva#4344: Add url extension to mime type list please test in all clients on all OSSes
Ubuntu22.04 (desktop-client 5.2.0):
.url
files get synced- no application to open it
Windows 11:
.url
files get synced - extension is not visible (expected)- links open in the respective app (browser, mail)
MacOs: @HanaGemela Could you do it in mac?
@ScharfViktor Any other particular things (or OS) to test here?
Tested on mac with 5.2.0 client and it passed
OCIS_SERVICE_ACCOUNT_ID = random UUID
OCIS_SERVICE_ACCOUNT_SECRET=random string
and MICRO_REGISTRY: "nats-js-kv"
shares:
project space:
files:
users
settings
notification
Remarks:
Incremental changes since 5.0.0-rc.2
search/pkg/search/search.go
: #8230Incremental changes since 5.0.0-rc.3
@ScharfViktor @TheOneRing @individual-it RC 4 is not the last RC.
e2e tests
5.0.0 beta-2
against s3:
Perhaps a test should be added for large file upload.
Perhaps a test should be added for large file upload.
There is such a test, and it passed. https://github.com/owncloud/web/blob/master/tests/e2e/cucumber/features/smoke/uploadResumable.feature - uploading file with 1Gb size
Perhaps a test should be added for large file upload.
There is such a test, and it passed. https://github.com/owncloud/web/blob/master/tests/e2e/cucumber/features/smoke/uploadResumable.feature - uploading file with 1Gb size
I see. I was thinking a little larger. The issue I'm encountering is that file uploads that take more than 30 minutes fail due to token expiry. I can reproduce this on the OCIS continual deployment test server using a 17gb upload. Documented here: owncloud/web#10474
I see. I was thinking a little larger. The issue I'm encountering is that file uploads that take more than 30 minutes fail due to token expiry. I can reproduce this on the OCIS continual deployment test server using a 17gb upload. Documented here: owncloud/web#10474
It seems that instance broken. I tried to do it localy (works fine).
we don't have to upload a large file to e2e-test and wait 30 minutes or more -> decreasing the time IDP_ID_TOKEN_EXPIRATION
helps in this case.
https://github.com/owncloud/ocis/releases/tag/v5.0.0-rc.6
docker pull owncloud/ocis:5.0.0-rc.6
smoke test with arm64 single binary on odroid successful :heavy_check_mark:
Automated smoke test passed in desktop-client with ocis version 5.0.0-rc.6
:heavy_check_mark:
Build: https://drone.owncloud.com/owncloud/client/17866
GUI Report: https://cache.owncloud.com/public/owncloud/client/17866/ocis/guiReportUpload/index.html
Mobile:
Tests over Android (v4.1.2), all passed ✅ : https://reports.cucumber.io/reports/540827db-6f11-47d5-b951-9f98cdc755c0
Tests over iOS (v12.1), all passed ✅ : https://reports.cucumber.io/reports/ec1ea409-c41d-464e-998b-bbb12e5566c7
Some manual testing also done, mainly regarding transfers. As smoke test is passed ✅
It's OK from my side
Compatibility test between 4.0.5 and 5.0.0-rc.1 using enabled Service accounts - looks good ✅
@micbar question about resharing: https://github.com/owncloud/docs-ocis/pull/739/files#diff-04cd79e526c8a7f0162d8fc5bc5fa8c501fe9e5899024268837c05a74349b26cR148-R149
it is enabled in rc.6
, I was sure that resharing was disabled (I already checked it) Looks like something is wrong.
I don't see OCIS_ENABLE_RESHARING=true
-> but resharing is enabled
Right! Big OMG moment, we just missed to change the default value. Needs to be done now.
From an engineering POV this:
@kulmann @tbsbdr @dragotin this is a GO from the backend and load testing teams.
Yes, GO! Great! Thanks to the whole team for this big effort :+1:
GO! What lasts a long time will finally be good - really looking forward to doogfood this release ❤️
GO! from web as well!
Beta Phase
release-5.0.0-beta.1
-> FEATURE FREEZEchangelog/CHANGELOG.tmpl
ocis-pkg/version/version.go
sonar-project.properties
changelog/5.0.0-beta.1_????_??_??
5.0.0-beta.1
5.0.0-beta.1
tag / BLOCKING for all further activityQA Phase
Extra QA Topics
Standard QA
[x] QA: Confirmatory testing (if needed)
[x] QA: Compatibility test @ScharfViktor
[x] QA: Performance test
[x] QA: Documentation test:
[x] QA: e2e with different deployment:
[x] QA: e2e with different storage:
[x] QA: Different clients:
[x] QA: Smoke test on Web Office
[x] QA: Smoke test Hello extension https://github.com/owncloud/ocis-hello/issues/137
[x] QA: Smoke test ldap @ScharfViktor
[x] QA: Collecting errors found
https://github.com/owncloud/ocis/issues/8003
https://github.com/owncloud/ocis/issues/7990
https://github.com/owncloud/ocis/issues/8070
https://github.com/owncloud/docs-ocis/pull/691
https://github.com/owncloud/ocis-charts/issues/458
https://github.com/owncloud/ocis/issues/8068
https://github.com/owncloud/ocis/issues/8060
https://github.com/owncloud/ocis/issues/8059
https://github.com/owncloud/docs-ocis/issues/692
After QA Phase
release-x.x.x
https://github.com/owncloud/ocis/pull/8679ocis-pkg/version/version.go
sonar-project.properties
changelog/x.x.x_???
vx.y.z
tag / BLOCKING for all further activityPost-release communication
docs-stable-x.y
branch based on the docs folder in the ocis repo @micbarx.y.z
release in the ocis-helm repo (frozen state) @wkloucek