owncloud / owncloud-updater-server

Server component that responds to ownCloud Server update requests
MIT License
2 stars 2 forks source link

update the updater to 10.10.0 #19

Open jnweiger opened 2 years ago

jnweiger commented 2 years ago

This supercedes the 10.9.1 update in https://github.com/owncloud/owncloud-updater-server/pull/17

As before, I am following the breadcrumbs from VicDeo, but this time I try to extrapolate to 10.10.0 Please review carefully.

xoxys commented 2 years ago

This repo does only some test stuff. The real updater server and its deployment is done on gitea. I can not help with this one.

jnweiger commented 2 years ago

@xoxys The testing here is now fixed. But then the build step fails. It basically tries to

# docker run --rm -ti owncloudops/nginx:latest sh -c 'apk --update add composer ; apk --update add php7'
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.16/community/x86_64/APKINDEX.tar.gz
(1/23) Installing php8-common (8.0.19-r0)
(2/23) Installing argon2-libs (20190702-r1)
(3/23) Installing ncurses-terminfo-base (6.3_p20220521-r0)
(4/23) Installing ncurses-libs (6.3_p20220521-r0)
(5/23) Installing libedit (20210910.3.1-r0)
(6/23) Installing pcre2 (10.39-r0)
(7/23) Installing xz-libs (5.2.5-r1)
(8/23) Installing libxml2 (2.9.14-r0)
(9/23) Installing php8 (8.0.19-r0)
(10/23) Installing php8-phar (8.0.19-r0)
(11/23) Installing brotli-libs (1.0.9-r6)
(12/23) Installing nghttp2-libs (1.47.0-r0)
(13/23) Installing libcurl (7.83.1-r1)
(14/23) Installing php8-curl (8.0.19-r0)
(15/23) Installing php8-iconv (8.0.19-r0)
(16/23) Installing oniguruma (6.9.8-r0)
(17/23) Installing php8-mbstring (8.0.19-r0)
(18/23) Installing php8-openssl (8.0.19-r0)
(19/23) Installing libbz2 (1.0.8-r1)
(20/23) Installing zstd-libs (1.5.2-r1)
(21/23) Installing libzip (1.8.0-r1)
(22/23) Installing php8-zip (8.0.19-r0)
(23/23) Installing composer (2.3.5-r0)
Executing busybox-1.35.0-r13.trigger
OK: 26 MiB in 40 packages
ERROR: unable to select packages:
  php7 (no such package):
    required by: world[php7]

The composer install pulls in php8, which we probably don't want. The install for php7 then fails. Was php7 support removed from that docker image?

xoxys commented 2 years ago

Yes.

xoxys commented 2 years ago

I can create a tag with the latest nginx base image that supports PHP7, but alpine has removed PHP 7 from the latest OS release so this need to be addressed anyway...

jnweiger commented 2 years ago

@xoxys Thank you, that would be helpful. I cannot yet say, if the updater works correctly with php8. I'd suggest, we first build a php7 based updater, so that we can complete the 10.10.0 post-release checklist.

xoxys commented 2 years ago

Well... There is a working and deployed php7 container image already, we don't need to fix this for 10.10 in this repo.