search

owncloud / owncloud-updater-server

Server component that responds to ownCloud Server update requests
MIT License
2 stars 2 forks source link

CI integration #3

Open VicDeo opened 3 years ago

VicDeo commented 3 years ago

In the previous repo we had Travis integration for phpunit and behat tests. Now we have no CI here.

VicDeo commented 3 years ago

@xoxys @phil-davis as we are approaching to 10.6 release at least make test should be checked for new PRs in this repo.

I foresee the test target to be broken as index.php was not migrated to this repo

VicDeo commented 3 years ago

make test will be fixed once https://github.com/owncloud/owncloud-updater-server/pull/4 is merged

xoxys commented 3 years ago

@VicDeo what's needed to be running for tests? This?

script:
  - sh -c "cd update-server/tests/integration/ && ../../vendor/bin/behat ."
  - sh -c "cd update-server/tests/unit/ && ../../vendor/bin/phpunit ."

That would be simple to integrate into Drone CI. But beside this as you mentioned 10.6 release please keep in mind that the configuration for the deployment is decoupled from this repo. This repository contains only the service source code and is used to build the docker image and the configuration in this repo will be overwritten during the container deployment process.

phil-davis commented 3 years ago

PR #5 got the behat make test and PHP unit make test-php-unit running in CI.

VicDeo commented 3 years ago

with https://github.com/owncloud/owncloud-updater-server/pull/9 localhost:8888 is not hardcoded into the code anymore