oyvindwe / connectlife-ha

ConnectLife integration for Home Assistant
GNU General Public License v3.0
62 stars 24 forks source link

Added device 009-128 (air conditioner) #110

Closed psycho202 closed 3 months ago

psycho202 commented 3 months ago

Added my model of AC. Seems similar to existing model 09-100, so copied but adjusted presets for my own use case.

Further improvements to data_dictionary for this model and possibly others:

psycho202 commented 3 months ago

image Example of f_cool_qvalue values in HA for this model

oyvindwe commented 3 months ago

Thank you for your contribution! ❤️

property f_votage corresponds to grid voltage, as measured by the indoor unit. Couldn't get this to work to add it as a property with the correct sensor device class. f_votage or f_voltage? Spelling errors seem to be quite common in this API. Probably not very useful, but did you try this:

- property: f_votage
sensor:
device_class: voltage
unit: V

property f_cool_qvalue corresponds to the BTU/hr of the unit, how much heat it's removing at that moment. Cool data to know how "hard" the aircon is working at a certain point in time.

I don't see any matching device class, but this should work:

- property: f_cool_qvalue
  sensor:
    unit: BTU/hr
    state_class: measurement

property t_fan_speed_s remains equal to t_fan_speed, so this property can probably be disabled by default?

Unmapped properties are hidden by default. Currently no support to disable properties completely, but that may be a nice feature to add.

psycho202 commented 3 months ago

Thanks @oyvindwe, tested and added the properties!

f_votage indeed is a typo in the API. Also added the f_heat_qvalue, some icons and their text mapping to the strings.json and en.json files.

oyvindwe commented 3 months ago

Tip for future PRs: Make a branch in your forks before committing changes, so you can keep main in sync with upstream repo.

psycho202 commented 3 months ago

Tip for future PRs: Make a branch in your forks before committing changes, so you can keep main in sync with upstream repo.

Thanks for the tip! I'm not a developer by trade, so I'm not very used to working with github :) Trying my best though!