Refactoring may be in order for strings.json and en.json.

oyvindwe / connectlife-ha

ConnectLife integration for Home Assistant

GNU General Public License v3.0

62 stars 24 forks source link

Refactoring may be in order for strings.json and en.json. #111

Closed psycho202 closed 3 months ago

psycho202 commented 3 months ago

Refactoring may be in order for strings.json and en.json. Fan modes "Middle_low" and "middle_high" are split off from the rest of the fan speeds. They're at lines 232 and 233 under fan_mode, whereas the rest of the fan modes are at lines 659 to 661 under t_fan_speed state

I took a look at specifically those fan modes, as I didn't find them at first glance. Possibly other values for different device types may also be split up like this.

oyvindwe commented 3 months ago

middle_low and middle_high are extensions to the Climate entity fan modes, which supports several modes OOTB.

f_fan_speed at line 659 is a select entity used by other types of devices (dehumidifier, water heater) that don't have fan mode OOTB.