search

p4535992 / foundryvtt-arms-reach

FoundryVTT Door little Utilities, Arms Reach for door
MIT License
3 stars 4 forks source link

Conflict with Drag Ruler #23

Closed LordOHelmet closed 2 years ago

LordOHelmet commented 3 years ago

Environment Details

Issue Description

When both modules, Arms Reach and Drag Ruler are enabled Drag ruler doesn't show the distance any more.

p4535992 commented 3 years ago

Sorry just tested seem to work fine on a new world i just created for this issue. Any exception on the web console ?

LordOHelmet commented 3 years ago

Drag Error

p4535992 commented 3 years ago

Starting from the fact that I don't understand why it does this to you and not me (make sure you have downloaded the latest version of the GURPS system and if possible using chrome), the problem is neither on my module or on the drag ruler module.

The "GURPSSpeedProvider" class on the file "gurps.js" file does not set a super constructor as described here

LordOHelmet commented 3 years ago

make sure you have downloaded the latest version of the GURPS system and if possible using chrome

Checked and verified

the problem is neither on my module or on the drag ruler module.

Though, it only happens when Arms Reach is also activated. Drag Ruler by itself woks fine.

I have also opend an issue ind the GURPS Github. Maybe they will come up with something.

p4535992 commented 3 years ago

Found a bug on the measure distance. I'm not sure if it was the cause of this problem, try version 2.0.8

LordOHelmet commented 2 years ago

Great it was working for the 2.0.10 release! But unfortunately it is broken with the 2.0.11 release!

Could you please provide me with the manifest URL for the 2.0.10 release so I can revert to it? Thanks!

LordOHelmet commented 2 years ago

Well, found the URL myself: https://github.com/p4535992/foundryvtt-arms-reach/releases/latest/download/module.json?version=2.0.10

But what I absolutely don't get - it still is not working after reverting to 2.0.10! I am so confused. Because yesterday it was definitely working. And the only update I did since than was Arms Reach from 2.0.10 to 2.0.11.

p4535992 commented 2 years ago

there shouldn't be any differences in functionality between 2.0.10 and 2.0.11 (just added the lights feature). Can I ask if you see the error with the windows application, or the browser, or both?

LordOHelmet commented 2 years ago

I checked the windows application with 2.0.11 and it works fine! All the same modules are enabled.

On the other hand I use the latest Chrome browser with Forge and still get this error: Error

Out of curiosity I also checked with the latest Firefox and get the same Browser issue. So I guess it is a problem with the Forge! Cause the error reads

Uncaught (in promise) SocketlibUnregisteredHandlerError: Function '_socketRecalculate' has not been registered as a socket handler. [Detected 2 packages: socketlib, foundryvtt-arms-reach] SocketlibError https://assets.forge-vtt.com/bazaar/modules/socketlib/1.0.9/src/errors.js:3

I will also open an issue at the Forge.

p4535992 commented 2 years ago

@LordOHelmet Before open a issue on forge chekhout the application on the local browser http://localhost:3000/game, and let me know if you get the issue

LordOHelmet commented 2 years ago

@p4535992 When I access the self hosted game via Chrome it also works fine!

p4535992 commented 2 years ago

@LordOHelmet In fact I have never tested on Forge because I use my personal VM Linux ... I should have thought of it first ... you also indicated that in the info ... unfortunately I don't know if i put back something before the weekend .. . Try to Open at Issue on Forge, but it probably is something of my module at the end.

LordOHelmet commented 2 years ago

Here is the thread to the issue I opened on The Forge: https://forums.forge-vtt.com/t/drag-ruler-and-foundry-vtt-arms-reach/15741

p4535992 commented 2 years ago

Should be fixed on 2.1.0 give a try

LordOHelmet commented 2 years ago

Thanks for the effort! It is working fine now!