search

p4535992 / foundryvtt-arms-reach

FoundryVTT Door little Utilities, Arms Reach for door
MIT License
3 stars 4 forks source link

Further conflicts between Drag-Ruler and FoundryVTT Arms Reach #26

Closed XtraButtery closed 2 years ago

XtraButtery commented 3 years ago

In order to submit an effective bug report, please include the following information along with your issue description.

Environment Details

Issue Description

In addition to the previously reported issue with drag ruler (#23) there is also an intermittent issue when both modules are installed where when dragging a token to move it, the movement will simply not occur. This error is incredibly intermittent and inconsistent, it occurred as frequently as every two or three moves and as infrequently as one in over thirty times. Distance does not seem to matter as I have observed this error happening in movements as small as one tile as well as over twenty. This error occurs on both square grids as well as hex grids.

This error has also been reported on the Drag Ruler's github page: https://github.com/manuelVo/foundryvtt-drag-ruler/issues/105

Screenshots and Error Logs:

Upon start the following error appears in the console:

image

(The same error in Firefox)

image

When dragging a token a slightly different error appears

image

When the movement fails the drag ruler remains in place, and the token also does not move.

image image

Right clicking on the canvas will cancel the movement and remove the drag ruler outputting the following error into the console:

image

the same error in Firefox: image

p4535992 commented 3 years ago

Found a bug on the measure distance. I'm not sure if it was the cause of this problem, try version 2.0.8

XtraButtery commented 3 years ago

Just updated all my modules and tried it again, still having all of the same issues I was having before. Tested it in the standalone application on Windows and also noticed the same bug where token movement doesn't happen however I can't find any errors in the console (that could just be me not knowing where to look)

Additionally it seems that the latest update has made drag-ruler a dependency which may present an issue for people wishing to use your module as they do appear to be conflicting. You might want to push out a hotfix to remove this dependency. I was enabling drag ruler first to make sure that the issue wasn't strictly drag ruler in my tests so I didn't realise it was already a hard dependency for the module.

p4535992 commented 2 years ago

Does the error still persists ?

XtraButtery commented 2 years ago

The first issue has been fixed, there are no longer errors upon every single move nor one upon loading Foundry.

The other more intermittent issue of a movement freezing upon dragging a token still occurs. I can't find a consistent trigger but drag a token enough times and it will eventually happen at least once.

When the movement freezes there are no errors until the movement is cancelled at which point the following error is posted into the console:

image

Tested this a minute ago with only the following modules: Drag Ruler 1.8.2 FoundryVTT Arms Reach v2.0.10 libWrapper 1.10.6.0 socketlib 1.0,9

As of the time of testing these all appear to be the most recent version.

p4535992 commented 2 years ago

@XtraButtery Can I ask you if he does this to you only for a specific scene and / or a specific actor?

p4535992 commented 2 years ago

@XtraButtery on this issue https://github.com/p4535992/foundryvtt-arms-reach/issues/23 we verified a problem with forge can you checkout the application on the local browser http://localhost:3000/game, and let me know if you get the issue?

XtraButtery commented 2 years ago

@p4535992 I was unable to reproduce the issue outside of Forge.

p4535992 commented 2 years ago

@p4535992 I was unable to reproduce the issue outside of Forge.

Thank you ! i don't know why he does this problem with forge ... i will try to ask the league for help.

p4535992 commented 2 years ago

Should be fixed on 2.1.0 give a try