search

p4535992 / foundryvtt-arms-reach

FoundryVTT Door little Utilities, Arms Reach for door
MIT License
3 stars 4 forks source link

Can "reach" further to the east #28

Closed pesky-wobbit closed 2 years ago

pesky-wobbit commented 2 years ago

Arms Reach Version v2.0.11 Players can open eastern doors from 10' away. In other directions, the maximum is 5' as expected.

p4535992 commented 2 years ago

Try out 2.0.12 and let me know if the issue i solved

pesky-wobbit commented 2 years ago

I don't see 2.0.12 in the in-game module browser. Should I try a manual install?

p4535992 commented 2 years ago

I don't see 2.0.12 in the in-game module browser. Should I try a manual install?

Just update the module clicking on "update" or "update all" on the modules page

pesky-wobbit commented 2 years ago

Yeah. That's not working. still at v2.011

pesky-wobbit commented 2 years ago

2.013 - Excellent! Works as expected North South East West! Small tweak needed, though. Doors that are diagonally adjacent sometimes do not open. Recommend an extra pixel or two allowed when calculating doors on the diagonals.

In this pic, the player can open door to the Northwest but not the Southeast. image

p4535992 commented 2 years ago

I have tried but it is not (at least for me), possible to find a mechanism for calculating the distance that correctly checks the diagonals if the interaction comes from the left or from the right. I can only hope for some update of the specific system you used (D & D5e, PF2, etc.), or foundryvtt, or as a very complex solution to be able to create a customized drag-ruler SpeedProvider for your use case that does the calculation you wanted.

KenGitsIt commented 2 years ago

2.013 - Excellent! Works as expected North South East West! Small tweak needed, though. Doors that are diagonally adjacent sometimes do not open. Recommend an extra pixel or two allowed when calculating doors on the diagonals.

In this pic, the player can open door to the Northwest but not the Southeast. image

I think this is a symptom of issue #35, which I just reported, and described the solution to. This isn't being triggered by the diagonal, but because the door is centered in the next column to the east. If the door bisected the grid square directly to the east of the token, you would encounter the same issue.

p4535992 commented 2 years ago

Should be finally fixed (for the wall distance) on 2.1.9 try out and let me know

pesky-wobbit commented 2 years ago

Works great. Thanks!

On Sat, Jan 15, 2022 at 9:47 AM 4535992 @.***> wrote:

Should be finally fixed (for the wall distance) on 2.1.9 try out and let me know

— Reply to this email directly, view it on GitHub https://github.com/p4535992/foundryvtt-arms-reach/issues/28#issuecomment-1013694219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADUSBU2LJWPUHE54OPNRHDUWGCI5ANCNFSM5E5M2AYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>