search

p4535992 / foundryvtt-arms-reach

FoundryVTT Door little Utilities, Arms Reach for door
MIT License
2 stars 4 forks source link

[BUG] Missing "." in ArmsReachHelper #55

Closed kagedansa closed 1 year ago

kagedansa commented 1 year ago

Module Version: v2.2.0

Lines 138 and 139 in ArmsReachHelper.js are missing a "." after "token.document"

Edit: In Addition please replace Line 96 const data = placeableObject.data? placeableObject.data: placeableObject; with const data = placeableObject.document ? placeableObject.document : placeableObject;

to avoid warnings.

Edit2: additionaly to the above in line 99 and 102 ".document" has to be removed.

p4535992 commented 1 year ago

Should be solved with 2.2.1 ty for the detailed ticket

kagedansa commented 1 year ago

There are a lot of warnings e.g. when opening doors. over 900 when opening just one door

localhost-1663325618182.log

I'm trying to figure out why.

kagedansa commented 1 year ago

It seems to be line 63 in ArmsReachHelper.js

const data = placeableObject.data ? placeableObject.data : placeableObject;

if i replace "data" with "document" the errors are gone (including the error-messages from stairway-support). But i am not sure if there are any side-effects with this change.

Unfortunately i have no time left today to do more investigation.

kagedansa commented 1 year ago

I have been testing these changes and the ones from #54 in my environment with doors and stairways for some time now. Everything seems to work without any problems or error messages.

However, I haven't tried any of the other options like tiles or drawings, yet.

p4535992 commented 1 year ago

It should be okay now with 2.2.3 and thanks again for the logs and advises, unfortunately I am still not "skilled" with the new fields of 10. Thanks for your patience.

kagedansa commented 1 year ago

Works for me now without warnings! Thanks alot!