search

p5py / p5

p5 is a Python package based on the core ideas of Processing.
https://p5.readthedocs.io
GNU General Public License v3.0
724 stars 120 forks source link

Not compatible with Python >=3.11 #466

Open mhechthz opened 8 months ago

mhechthz commented 8 months ago

On windows the library is not compatible with Python 3.11 since Pillow 9.0.x is not compatible with Python 3.11. Compilation is needed which is never a good idea since it failes on most systems. Python 3.10 works well but is outdated now.

github-actions[bot] commented 8 months ago

Thank you for submitting your first issue to p5py

Gyan313 commented 8 months ago

@mhechthz can we not change Pillow to its latest version 10.1.0 which is compatible with python 3.11 ? It worked for me so thats why I am suggesting. And if there is any issue with that let me know as I am new to open Source ✌️.

mhechthz commented 8 months ago

Yes @Gyan313, this is exactly what I would like to be changed. So I can directly install the library using pip instead of compiling it on my own machine during installation (which never works on many windows machines and for many colleagues I know).

tushar5526 commented 8 months ago

Thanks, @mhechthz @Gyan313 for testing it out on windows. I should probably add a basic GHA for windows that installs the p5 on it. Would any of you like to make a PR to bump the Pillow dependency?

Gyan313 commented 8 months ago

@tushar5526 Hi, I'm also working on integrating a pre-commit hook to p5, and I'm currently addressing some flake8 issues. Once I'm finished, I'll submit a pull request to update the Pillow dependency. Whether or not I resolve the flake8 problem, I'll still create a PR for Pillow today. ✌️❤️

tushar5526 commented 8 months ago

Hey @Gyan313 awesome to hear about your plans! Just a heads-up on something related to pre-commit already in the pipeline - https://github.com/p5py/p5/pull/460