search

packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

Patch'es original author & commit message not preserved #110

Open jpopelka opened 3 years ago

jpopelka commented 3 years ago

For example:

I'd expect to see Packit as a committer but not as the original author. And also the original commit messages disappeared.

TomasTomecek commented 3 years ago

This one has an easy answer: the patches are applied via specfile's %prep, so when they are applied with /usr/bin/patch, we just let patch do the job and get on with our lives. If packagers wanted commits to be owned by authors, they would need to let git apply it (via %autopatch -S git[_am])

At this point I wanted to wontfix this but since you are not a packager, I'm thinking from a different perspective now. Yours.

It would indeed be nice if authorship was correct if possible - since we are hooked into the patch process and the data are there, we could somehow get them and do git commit --amend --author ... after the patch is applied by /usr/bin/patch