Closed lachmanfrantisek closed 3 years ago
Can you explain why we install sentry-sdk and rebase-helper from github instead of PyPI?
Build succeeded.
Can you explain why we install sentry-sdk and rebase-helper from github instead of PyPI?
I've included some explanation, but the main problem is that for some reason, the rebasehelper
can't be installed from PyPI during the built event it works well when I do the steps manually inside a container.
Build succeeded.
Build succeeded.
Build succeeded (gate pipeline).
@lachmanfrantisek would it make sense to base the worker image on top of the dist2src image built from Containerfile?
When a new dependency is needed to make conversion work, we update that one. Workers need the same dependencies.
@csomh Yes, it makes sense. Will send a PR.
We might want to move some logic to the playbook as well, but that's a different task.
@csomh It looks like we are not building that image in docker-hub -- I'll create an issue instead.
The sentry-sdk and rebase-helper packages are installed from GitHub via pip.
Signed-off-by: Frantisek Lachman flachman@redhat.com