Closed jpopelka closed 3 years ago
Expectation in the tests needs to be updated, too.
Build failed.
What about the test_convert.py::test_conversions[kernel-c8s] FAILED
? Can I ignore that?
I don't think it's related to my change:
subprocess.CalledProcessError: Command
'['git', 'clone', '-b', 'c8s', 'https://git.centos.org/rpms/kernel.git', '/tmp/pytest-of-root/pytest-0/test_conversions_kernel_c8s_0/d/kernel']'
returned non-zero exit status 128.
What about the
test_convert.py::test_conversions[kernel-c8s] FAILED
? Can I ignore that?
I would say, yes. I think the reason for the failure is that the test will actually clone that repo, and download the sources, which are not small... so we kinda abusing git.centos.org
for testing purposes. Not sure if we can or should change this :thinking:
See https://git.stg.centos.org/source-git/ostree/commits/c8s where the
sg-start
tag should have been moved to theAdd sources defined in the spec file
commit.