[worker] git push --tags --force

packit / dist-git-to-source-git

Converting dist-git to source-git

MIT License

4 stars 9 forks source link

[worker] git push --tags --force #118

Closed jpopelka closed 3 years ago

jpopelka commented 3 years ago

See https://git.stg.centos.org/source-git/ostree/commits/c8s where the sg-start tag should have been moved to the Add sources defined in the spec file commit.

csomh commented 3 years ago

Expectation in the tests needs to be updated, too.

softwarefactory-project-zuul[bot] commented 3 years ago

Build failed.

pre-commit : SUCCESS in 2m 11s
dist2src-tests : FAILURE in 37m 00s
dist2src-deployment-tests : SUCCESS in 9m 45s

jpopelka commented 3 years ago

What about the test_convert.py::test_conversions[kernel-c8s] FAILED? Can I ignore that? I don't think it's related to my change:

subprocess.CalledProcessError: Command
'['git', 'clone', '-b', 'c8s', 'https://git.centos.org/rpms/kernel.git', '/tmp/pytest-of-root/pytest-0/test_conversions_kernel_c8s_0/d/kernel']'
returned non-zero exit status 128.

csomh commented 3 years ago

What about the test_convert.py::test_conversions[kernel-c8s] FAILED? Can I ignore that?

I would say, yes. I think the reason for the failure is that the test will actually clone that repo, and download the sources, which are not small... so we kinda abusing git.centos.org for testing purposes. Not sure if we can or should change this :thinking: