search

packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

Failed run after installation #12

Closed dhodovsk closed 4 years ago

dhodovsk commented 4 years ago 
[hodi@localhost dist-git-to-source-git]$ pipenv shell
Creating a virtualenv for this project…
Pipfile: /tmp/playground/dist-git-to-source-git/Pipfile
Using /usr/bin/python3 (3.7.4) to create virtualenv…
⠼ Creating virtual environment...Already using interpreter /usr/bin/python3
Using base prefix '/usr'
New python executable in /home/hodi/.local/share/virtualenvs/dist-git-to-source-git-ADR4-AYb/bin/python3
Also creating executable in /home/hodi/.local/share/virtualenvs/dist-git-to-source-git-ADR4-AYb/bin/python
Installing setuptools, pip, wheel...done.

✔ Successfully created virtual environment! 
Virtualenv location: /home/hodi/.local/share/virtualenvs/dist-git-to-source-git-ADR4-AYb
Launching subshell in virtual environment…
 . /home/hodi/.local/share/virtualenvs/dist-git-to-source-git-ADR4-AYb/bin/activate
[hodi@localhost dist-git-to-source-git]$  . /home/hodi/.local/share/virtualenvs/dist-git-to-source-git-ADR4-AYb/bin/activate
(dist-git-to-source-git) [hodi@localhost dist-git-to-source-git]$ pipenv install
Installing dependencies from Pipfile.lock (349f6f)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 48/48 — 00:02:08
(dist-git-to-source-git) [hodi@localhost dist-git-to-source-git]$ ./dist2src.py --help
Traceback (most recent call last):
  File "./dist2src.py", line 13, in <module>
    import sh
ModuleNotFoundError: No module named 'sh'

Workaround: Install deps manually, including get_source.sh script

lachmanfrantisek commented 4 years ago

Why we use pipenv here? Don't we want to use the same tooling across all the projects?

Why agreed on not using Pipenv some time ago..;)

csomh commented 4 years ago

The missing sh should have been fixed in #6 already.

Although the installation of get_sources.sh is not explicitly mentioned, but the README does call out its usage. Should this be made more explicit?

dhodovsk commented 4 years ago

The log is from yesterday on master. Could you please verify that it is really fixed?

csomh commented 4 years ago 
 ~/src/github.com/packit-service/dist-git-to-source-git (master u= origin/master)
🐝 pipenv --rm
Removing virtualenv (/home/hcsomort/.virtualenvs/dist-git-to-source-git-00p6mKAy)…
 ~/src/github.com/packit-service/dist-git-to-source-git (master u= origin/master)
🐝 pipenv install
Creating a virtualenv for this project…
Pipfile: /home/hcsomort/src/github.com/packit-service/dist-git-to-source-git/Pipfile
Using /usr/bin/python3.7m (3.7.7) to create virtualenv…
⠏ Creating virtual environment...Already using interpreter /usr/bin/python3.7m
Using base prefix '/usr'
New python executable in /home/hcsomort/.virtualenvs/dist-git-to-source-git-00p6mKAy/bin/python3.7m
Also creating executable in /home/hcsomort/.virtualenvs/dist-git-to-source-git-00p6mKAy/bin/python
Installing setuptools, pip, wheel...
done.
Running virtualenv with interpreter /usr/bin/python3.7m

✔ Successfully created virtual environment!
Virtualenv location: /home/hcsomort/.virtualenvs/dist-git-to-source-git-00p6mKAy
Installing dependencies from Pipfile.lock (349f6f)…
  🐍   ▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉▉ 48/48 — 00:00:58
To activate this project's virtualenv, run pipenv shell.
Alternatively, run a command inside the virtualenv with pipenv run.
 ~/src/github.com/packit-service/dist-git-to-source-git (master u= origin/master)
🐝 pipenv shell
Launching subshell in virtual environment…
 . /home/hcsomort/.virtualenvs/dist-git-to-source-git-00p6mKAy/bin/activate
 ~/src/github.com/packit-service/dist-git-to-source-git (master u= origin/master)
🐝  . /home/hcsomort/.virtualenvs/dist-git-to-source-git-00p6mKAy/bin/activate
(dist-git-to-source-git-00p6mKAy)  ~/src/github.com/packit-service/dist-git-to-source-git (master u= origin/master)
🐝 ./dist2src.py --help
Usage: dist2src.py [OPTIONS] COMMAND [ARGS]...

  Script to convert the tip of a branch from a dist-git repository into a
  commit on a branch in a source-git repository.

...

Maybe try pipenv sync (or pipenv --rm and then pipenv install again)?

dhodovsk commented 4 years ago

That's really weird. On the system from yesterday, I had pipenv freshly installed. But since this is only my and not blocking problem I am closing, Thanks :)