updates: correctly lay new commits on top of old

[TomasTomecek]

there are multiple fixes here:

• git_repo.has_ref = bu default, remote refs are not part of git.repo.branches - one needs to check repo.remote.refs
• we were not correctly committing changes in BUILD/ git repo which are created during %prep
• setting BUILD_repo_path as a property
• when target source git repo branch is not checked out but it's present, it's an update

Fixes #117

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 25s
• dist2src-tests : FAILURE in 20m 55s
• dist2src-deployment-tests : SUCCESS in 9m 35s

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 08s
• dist2src-tests : FAILURE in 31m 01s
• dist2src-deployment-tests : SUCCESS in 13m 19s

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 44s
• dist2src-tests : TIMED_OUT in 1h 00m 27s
• dist2src-deployment-tests : SUCCESS in 13m 27s

[TomasTomecek]

recheck Sample test failure:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/packit/api.py", line 490, in create_srpm
    self.up.prepare_upstream_for_srpm_creation(upstream_ref=upstream_ref)
  File "/usr/local/lib/python3.6/site-packages/packit/upstream.py", line 681, in prepare_upstream_for_srpm_creation
    self.prepare_upstream_using_source_git(upstream_ref)
  File "/usr/local/lib/python3.6/site-packages/packit/upstream.py", line 727, in prepare_upstream_using_source_git
    self.create_patches_and_update_specfile(upstream_ref)
  File "/usr/local/lib/python3.6/site-packages/packit/upstream.py", line 750, in create_patches_and_update_specfile
    upstream=upstream_ref, destination=str(self.absolute_specfile_dir)
  File "/usr/local/lib/python3.6/site-packages/packit/upstream.py", line 229, in create_patches
    return pg.create_patches(upstream, destination, files_to_ignore=files_to_ignore)
  File "/usr/local/lib/python3.6/site-packages/packit/patches.py", line 459, in create_patches
    patch_list = self.process_git_am_style_patches(patch_list)
  File "/usr/local/lib/python3.6/site-packages/packit/patches.py", line 397, in process_git_am_style_patches
    top_commit = patch_list[-1]
IndexError: list index out of range

We need packit 0.20 or packit/packit#1000

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 04s
• dist2src-tests : TIMED_OUT in 1h 00m 24s
• dist2src-deployment-tests : SUCCESS in 11m 03s

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 1m 57s
• dist2src-tests : FAILURE in 16m 48s
• dist2src-deployment-tests : SUCCESS in 12m 06s

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 05s
• dist2src-tests : TIMED_OUT in 1h 00m 27s
• dist2src-deployment-tests : SUCCESS in 10m 40s

[TomasTomecek]

recheck I just don't understand the timeout - some tests take ~5 minutes (!) to complete. They run just fine for me locally.

Trying recheck today before I start digging deeper.

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 05s
• dist2src-tests : TIMED_OUT in 1h 00m 34s
• dist2src-deployment-tests : RETRY_LIMIT in 6m 24s

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 1m 56s
• dist2src-tests : FAILURE in 39m 54s
• dist2src-deployment-tests : RETRY_LIMIT in 6m 11s

[TomasTomecek]

fatal: unable to access 'https://git.stg.centos.org/source-git/upower.git/': Failed to connect to git.stg.centos.org port 443: Connection timed out

@_@

[TomasTomecek]

recheck

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 2m 32s
• dist2src-tests : FAILURE in 43m 32s
• dist2src-deployment-tests : SUCCESS in 15m 34s

[TomasTomecek]

recheck

[softwarefactory-project-zuul[bot]]

Build failed.

• pre-commit : SUCCESS in 1m 51s
• dist2src-tests : FAILURE in 27m 09s
• dist2src-deployment-tests : SUCCESS in 10m 25s

[softwarefactory-project-zuul[bot]]

Build succeeded.

• pre-commit : SUCCESS in 2m 12s
• dist2src-tests : SUCCESS in 28m 08s
• dist2src-deployment-tests : SUCCESS in 10m 59s

[softwarefactory-project-zuul[bot]]

Build succeeded (gate pipeline).

• pre-commit : SUCCESS in 2m 29s

[TomasTomecek]