Closed lbarcziova closed 3 years ago
Build failed.
Looks OK, just, looking at the process_message() it's quite big, maybe it's time to start thinking about dividing it into more methods. Maybe all the code that you're putting into try: except: could be separated into one?
Yeah, was thinking about it, but wanted to make a quick fix for this. But thanks to your comment when I tested it more I realised that logger.removeHandler()
was not enough (because it was called on 'dist2src.worker.processor' logger, not 'dist2src').
EDIT: I will make the division into more methods in the followup PR, since there will be more changes and I would like to merge this now
Build failed.
Build succeeded.
Build succeeded (gate pipeline).
Nice, we didn't need to cheat zuul :)
Related to #122 , remove the file handler at the end of processing (I was checking the logs and realised the files are too big because the file handler is not removed until a new update is being processed).