search

packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

fist example of requre test for d2s #139

Closed jscotka closed 2 years ago

softwarefactory-project-zuul[bot] commented 3 years ago

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

TomasTomecek commented 3 years ago

please rebase so we can see what this does in the CI system

softwarefactory-project-zuul[bot] commented 3 years ago

Build succeeded.

TomasTomecek commented 3 years ago

just played with this locally and the speedup is not significant:

with test data

== 1 passed, 5 warnings in 10.76s ==

without test data:

== 1 passed, 5 warnings in 13.47s ==

I am actually thinking if it's worth rebuilding our images for testing periodically (once a week?) and adding all test data in there during build. Then we would just pull an image in CI and we wouldn't need to build nor pull anything.

jscotka commented 3 years ago

just played with this locally and the speedup is not significant:

with test data

== 1 passed, 5 warnings in 10.76s ==

without test data:

== 1 passed, 5 warnings in 13.47s ==

I am actually thinking if it's worth rebuilding our images for testing periodically (once a week?) and adding all test data in there during the build. Then we would just pull an image in CI and we wouldn't need to build nor pull anything.

Yep, probably significant difference could be found for some bigger packages, question is how long take dist2sourcegit operations, if downloading sources is just some percentage of the whole time amount, so that it cannot improve it much and another question is if requre could help in case some E2E test, where it try also upload some archives, sources via ogr, and it can increase speed more significantly.

For this test, just one file is stored, so no other requre options are used, like storing network requests. or remote git operations.

As you've pinpointed in case these data could be stored in the built images, instead of git directly, seems like very nice solution.

TomasTomecek commented 2 years ago

I am closing this PR as this repository is going to be archived.