packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

git: Disable detecting renames #158

Closed csomh closed 3 years ago

csomh commented 3 years ago

Updating repositories with a large number of files might fail when file renames are detected by Git. This happens when merge is involved in some way, for example during cherry-picks.

Tried increasing merge.renameLimit to 999999, but this did not reliably fix the issues. Disabling rename detection did.

If my understanding is correct this will cause renames to show up as separate rm and add operations in the Git history. This should be fine as the usefulness of the source-git history is already limited.

Fixes #157.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

csomh commented 3 years ago

@TomasTomecek ptal and let me know if you think this change is okay or not. History will be changed somewhat (no renames), but I think that's fine as it's already pretty noisy.

softwarefactory-project-zuul[bot] commented 3 years ago

Build failed.

csomh commented 3 years ago

should we just skip kernel tests in CI?

This is what I did for the last couple of PRs :confused: I think the kernel test takes up too much storage. Discussing and fixing this could be done outside of this PR. WDYT?

TomasTomecek commented 3 years ago

should we just skip kernel tests in CI?

This is what I did for the last couple of PRs confused I think the kernel test takes up too much storage. Discussing and fixing this could be done outside of this PR. WDYT?

agreed

:rocket: