search

packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

Configure the CronJob to use the worker image from Quay.io #235

Closed csomh closed 2 years ago

csomh commented 2 years ago

Instead of referencing the image from the internal image stream, directly reference the worker image in Quay.io (or any other registry it might be stored in). Removing this indirection should ensure the image to be updated each time the CronJob runs.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded.

csomh commented 2 years ago

Removing this indirection should ensure the image to be updated each time the CronJob runs.

For a (cron) job, the image stream indirection has not much sense, indeed. On the other hand, it should work with it as well if the image stream is configured (which it should be) with auto_import_images: true.

Yes, indeed, but given the incompatibilities of the CronJob API versions between OpenShift 3.X and 4.X, which break the update mechanism when using image streams in 4.X, and given that we use 3.X for testing but 4.X in production, this seemed to be the best way to keep the image up to date in future jobs, while also making the tests pass.

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded (gate pipeline).