search

packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

readme: document why tests need to run in root containers #41

Closed TomasTomecek closed 4 years ago

TomasTomecek commented 4 years ago

https://github.com/packit/dist-git-to-source-git/pull/31#pullrequestreview-474268314

softwarefactory-project-zuul[bot] commented 4 years ago

Build succeeded.

lachmanfrantisek commented 4 years ago

And btw, it's really painful that the tests are triggering the container engine. You can't run the tests in a container and need to have every packit dependency on the host and not everything can be installed via virtualenv.

=> What about being able to run the whole test suite inside a container? (The pytest will run inside that container.)

TomasTomecek commented 4 years ago

And btw, it's really painful that the tests are triggering the container engine. You can't run the tests in a container and need to have every packit dependency on the host and not everything can be installed via virtualenv.

=> What about being able to run the whole test suite inside a container? (The pytest will run inside that container.)

Feel free to fix it :P

softwarefactory-project-zuul[bot] commented 4 years ago

Build failed (gate pipeline).

lachmanfrantisek commented 4 years ago

Feel free to fix it :P

Done..;) #43

softwarefactory-project-zuul[bot] commented 4 years ago

Build succeeded.

softwarefactory-project-zuul[bot] commented 4 years ago

Build succeeded (gate pipeline).