copy only sources defined in specfile

packit / dist-git-to-source-git

Converting dist-git to source-git

MIT License

4 stars 9 forks source link

copy only sources defined in specfile #44

Closed dhodovsk closed 4 years ago

softwarefactory-project-zuul[bot] commented 4 years ago

Build failed.

pre-commit : FAILURE in 2m 44s
dist2src-tests : FAILURE in 11m 17s

softwarefactory-project-zuul[bot] commented 4 years ago

Build failed.

pre-commit : FAILURE in 2m 57s
dist2src-tests : SUCCESS in 13m 42s
dist2src-tests-inside-container : ERROR Unable to find playbook /var/lib/zuul/builds/29b11dd53be9424381979a0391270d44/untrusted/project_0/github.com/packit/dist-git-to-source-git/zuul-tests-inside-container.yaml in 5s

softwarefactory-project-zuul[bot] commented 4 years ago

Build failed.

pre-commit : FAILURE in 3m 11s
dist2src-tests : SUCCESS in 13m 21s
dist2src-tests-inside-container : SUCCESS in 13m 55s

softwarefactory-project-zuul[bot] commented 4 years ago

Build succeeded.

pre-commit : SUCCESS in 2m 47s
dist2src-tests : SUCCESS in 12m 40s
dist2src-tests-inside-container : SUCCESS in 12m 14s

TomasTomecek commented 4 years ago

I just discovered one issue: rebase-helper.get_source returns also the tarball:

 " using a temp directory.".format(parent))
> /usr/local/lib/python3.6/site-packages/dist2src/core.py(364)copy_all_sources()
    363         import ipdb; ipdb.set_trace()
--> 364         for file_ in self.dist_git_spec.get_sources():
    365             file_dest = sg_path / Path(file_).name

ipdb> self.dist_git_spec.get_sources()
['/d/dnf/SOURCES/dnf-4.2.23.tar.gz']

I am debating whether this is a problem or not.

But since we are not interacting with lookaside cache in source-git, I'd say this is a good thing that we store the tarball alongside.