search

packit / dist-git-to-source-git

Converting dist-git to source-git
MIT License
4 stars 9 forks source link

use absolute paths to reference git repos #79

Closed TomasTomecek closed 3 years ago

TomasTomecek commented 3 years ago

running other commands than convert can result into "no such file or directory" because: 1) if you pass a relative path to the command 2) and we change dir when running rpmbuild

With this change we make all paths absolute so will no longer happen.

softwarefactory-project-zuul[bot] commented 3 years ago

Build succeeded.

TomasTomecek commented 3 years ago

nice, I didn't know this would work, I thought that python would eval the dist_git_path.absolute() before evaluating the if-condition

but that doesn't seem to be the case, thanks!

softwarefactory-project-zuul[bot] commented 3 years ago

Build failed.

TomasTomecek commented 3 years ago

recheck

softwarefactory-project-zuul[bot] commented 3 years ago

Build succeeded.

softwarefactory-project-zuul[bot] commented 3 years ago

Build succeeded (gate pipeline).