pact-foundation / pact_broker

Enables your consumer driven contracts workflow

http://pactflow.io

MIT License

702 stars 174 forks source link

Delete pacts by branch is not deleting the pacts #628

Open bethesque opened 1 year ago

bethesque commented 1 year ago

Pre issue-raising checklist

Software versions

Expected behaviour

Pacts are deleted

Actual behaviour

Pacts are not deleted

Steps to reproduce

DELETE https://broker/pacts/provider/my_provider/consumer/my_consumer/branch/chore%2Fupdate-dependencies

Relevant log files

mefellows commented 4 months ago

Following up on this, it seems to always return a 200 so long as the consumer/provider pair exists, no matter what branch you give it. In fact, as long as both pacticipants exist (even if no integration exists) it still returns a 200. You can even pass in the same pacticipant for both the provider and consumer.

github-actions[bot] commented 1 month ago

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-2239). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

bethesque commented 2 weeks ago

Low priority.

This is not a very useful endpoint anyway. If you want to clean up branch related data for a pacticipant, you want to delete the pacts for all consumers for that branch, not just for a specific consumer. I think I just wrote this endpoint because I was trying to match all the previous endpoints that had tags in them. I don't know if anyone has ever used it except for me. You could try checking the pactflow logs to see if it's ever been used.

mefellows commented 1 week ago

Thanks Beth, removing smartbear supported label given low priority.