`pact_content_modification_not_allowed` error message uses provider name where it should use consumer name.

pact-foundation / pact_broker

Enables your consumer driven contracts workflow

http://pactflow.io

MIT License

708 stars 177 forks source link

`pact_content_modification_not_allowed` error message uses provider name where it should use consumer name. #655

Closed jladieu closed 10 months ago

jladieu commented 11 months ago

While troubleshooting a pact_content_modification_not_allowed we noticed that the provider name was being used in both the provider & consumer portions of the error message.

Actual message:

foo_service version 1.2.3 and provider foo_service

Expected message:

bar_service version 1.2.3 and provider foo_service

The offending LOC appears to be here:

https://github.com/pact-foundation/pact_broker/blob/e2b2fcf2feb848e6e1ad9931032e75ea08790a93/lib/pact_broker/contracts/service.rb#L70

YOU54F commented 10 months ago

Good catch @jladieu - Would you be open to a PR so you can get attribution :)

bethesque commented 10 months ago

I actually came across this myself the other day, and fixed it in https://github.com/pact-foundation/pact_broker/commit/9830afc53ddc1b2fa1c7ff455d005d3b5800f564

bethesque commented 10 months ago

It's out in pactbroker:2.114.0-pactbroker2.108.0