pact-foundation / pact_broker

Enables your consumer driven contracts workflow
http://pactflow.io
MIT License
708 stars 175 forks source link

fix: result will not be returned from ensure incase of an error also result variable is unused #724

Closed pahnin closed 2 months ago

pahnin commented 2 months ago
YOU54F commented 2 months ago

I agree, the only place I can find it used is the following, and it doesn't look like the returned result is used.

https://github.com/pact-foundation/pact_broker/blob/ee5e19472682a604d5b753541f7f5f3cbfaa4bea/lib/pact_broker/db/advisory_lock.rb#L30

Small bit of advice that was given to me when considering commit messages and how they are shown to users below

I'd also just note that the commit message with a fix: will be shown in the consumer facing changelog.

Maybe something like the following would be better.

chore: remove unused result from pg_advisory_lock

This way

  1. It doesn't go in the changelog as its a chore
  2. You can understand what the change does, without having to read the commit delta