search

paf31 / purescript-thermite

A simple PureScript wrapper for React
MIT License
350 stars 55 forks source link

upgrade purescript-react and use purescript-react-dom #56

Closed justinwoo closed 8 years ago

justinwoo commented 8 years ago

introduces package.json to install react dependencies and make testing easier.

also shims CommonJS require() for purescript-react and react-dom.

effectively upgrades ps-thermite to react 0.14.x. please let me know if you don't want some of these changes, i can remove them as needed.

pkamenarsky commented 8 years ago

:+1:

The current version of thermite/react throws warnings with newer versions of React, like:

Warning: input is a void element tag and must not have `children` or use `props.dangerouslySetInnerHTML`. Check the render method of null.

Maybe this will fix it, if not then I'll fix this in purescript-react.

paf31 commented 8 years ago

Looks good! Sorry for the delay, I'll test this out later today and put out a release.

paf31 commented 8 years ago

Thanks!

justinwoo commented 8 years ago

:beers: