search

paf31 / purescript-thermite

A simple PureScript wrapper for React
MIT License
350 stars 55 forks source link

React 16 #98

Closed dwhitney closed 5 years ago

dwhitney commented 6 years ago

This upgrades Thermite to the latest versions of all of its dependencies along with React 16.02.

The latest purescript-react added a render type variable to its Render type, so I fixed ReactElement to it, which I believe will work, but someone should review.

Thanks!

dwhitney commented 6 years ago

it's gone now

On Wed, Jan 24, 2018 at 4:43 PM, Irakli Safareli notifications@github.com wrote:

@safareli commented on this pull request.

In package.json https://github.com/paf31/purescript-thermite/pull/98#discussion_r163687388 :

}, "devDependencies": {

  • "pulp": "^11.0.0",
  • "purescript-psa": "^0.5.0",
  • "purescript": "^0.11.1",
  • "rimraf": "^2.5.4"
  • "bower": "^1.8.2",

Why add bower?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/paf31/purescript-thermite/pull/98#pullrequestreview-91341510, or mute the thread https://github.com/notifications/unsubscribe-auth/AACCoRjFFJf5BonNUhrnqcw83RtrtGH9ks5tN6P3gaJpZM4Rqmau .

dwhitney commented 6 years ago

I was working with thermite a bit more today and realized that createReactSpec adds a redundant div, which is kind of annoying. This can be gotten rid of if the ReactRender type is fed an Array React.ReactElement. I think this would be better, but probably needs discussion

athanclark commented 5 years ago

@dwhitney I've uploaded thermite v6.0.1 which is purs v0.12.x compatible, and react v16.x compatible. Sorry for this wasted effort!