search

panakour / google-analytics

Get data from google analytics (API v4) using PHP
MIT License
26 stars 10 forks source link

Allow array of expressions in dimension filters #1

Closed elanclarkson closed 6 years ago

elanclarkson commented 6 years ago

Hi there - just wanted to say thanks very much for creating this package! It really is an easy and simple solution to interfacing with Google's latest v4 API.

I've just made a minor adjustment for my use case, which is to remove the type hinting for the expression parameter when setting the dimension filter, thus enabling us to optionally pass an array for filtering with the 'IN_LIST' operator.

More info here: https://developers.google.com/analytics/devguides/reporting/core/v4/rest/v4/reports/batchGet#DimensionFilterClause

panakour commented 6 years ago

@elanclarkson Thank you very much for your PR. It would be really helpful if you can update the README with one use case using IN_LIST operator.

panakour commented 6 years ago

Let me know if you have the time to update the readme so as I wait for it before I merge your PR.

elanclarkson commented 6 years ago

@panakour sorry for the delay, was really busy on this project. I have updated the README. :)

panakour commented 6 years ago

Thanks