search

pangeachat / client

Learn a language while texting your friends
https://krille-chan.github.io/fluffychat/
GNU Affero General Public License v3.0
2 stars 2 forks source link

Clicking a word should give practice on that word #1049

Open wcjord opened 3 days ago

wcjord commented 3 days ago

TO TEST: Click a word on a message. The toolbar show open to a word meaning practice activity with that message unless you've already done that kind of activity with that word within the last 24 hours.

linhtphung commented 2 days ago

I haven't seen this happen. When I clicked on a word that I know I haven't practiced on, this just spins. image @wcjord

linhtphung commented 2 days ago

This works on testflight staging

ggurdin commented 7 hours ago

This doesn't seem to work on Android

wcjord commented 7 hours ago

@ggurdin I'd like your help with this please!

ggurdin commented 7 hours ago

On it!

ggurdin commented 7 hours ago

It's a bit confusing that even when I click on a word, it still checks if that word is qualified for an activity. For instance, the word "podrias" in a bot message had no eligible activity types, so I didn't get an activity for that word.

Would it make sense to have less strict rules for deciding whether to give a clicked-on token an activity? (One worry in this case would be the user unintentionally clicking on a word that they don't want/need to practice because they want to select the message, not the specific word where their cursor/thumb landed)

ggurdin commented 6 hours ago

That seems to be the issue. Clicking on a wed to get an activity works when activities are available/enabled for a given token. But they're not available for a large number of tokens, so it's confusing.

wcjord commented 6 hours ago

Yup, was wrestling with this. The rules are less strict currently. Potentially they should be even less strict. Obviously confusing for you as a test user.

Will Jordan-Cooley CEO and Founder Pangea Chat https://www.pangeachat.com

On Fri, Nov 22, 2024 at 4:15 PM ggurdin @.***> wrote:

It's a bit confusing that even when I click on a word, it still checks if that word is qualified for an activity. For instance, the word "podrias" in a bot message had no eligible activity types, so I didn't get an activity for that word.

Would it make sense to have less strict rules for deciding whether to give a clicked-on token an activity? (One worry in this case would be the user unintentionally clicking on a word that they don't want/need to practice because they want to select the message, not the specific word where their cursor/thumb landed)

— Reply to this email directly, view it on GitHub https://github.com/pangeachat/client/issues/1049#issuecomment-2494822801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYPKFNNEUPR3TSP6JJOBC32B6NF5AVCNFSM6AAAAABSCVYGOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJUHAZDEOBQGE . You are receiving this because you modified the open/close state.Message ID: @.***>