search

pangeachat / client

Learn a language while texting your friends
https://krille-chan.github.io/fluffychat/
GNU Affero General Public License v3.0
1 stars 2 forks source link

add discussion topic and keywords min max lines with max length #370

Closed WilsonLe closed 3 months ago

ggurdin commented 3 months ago

Hi @WilsonLe ! What's the benefit of having the "responds to reaction" button disabled, rather than commented out for the time being?

WilsonLe commented 3 months ago

I left the UI in as a way to inform user on how to use the bot. Although the bot sends the instruction when it joins, not every user in the room can see its join message to know how to interact with the bot.

The common case is that a user creates a room with the bot, then invites other users to join afterwards. By then, the bot join message might have been deep in the room's timeline so it is not practical to expect user to know that bot "responds to reaction".

ggurdin commented 3 months ago

That makes sense. Is it possible to have the check box checked, to indicate that the settings is still active?

WilsonLe commented 3 months ago

It is still active in the sense that bot still responds to reactions. If we enable this checkbox, I think users would be more confused if they toggle the checkbox and the checkbox is still on (we are forcing the option to be always on for now).

ggurdin commented 3 months ago

Sorry, what I meant was more along the lines of - can the checkbox be both checked and disabled at the same time, or does having that widget disabled prevent its value from being true?

WilsonLe commented 3 months ago

It seems (by running the client) that they can be both disabled (in a sense that user cannot interact with it) and be true (through default values) at the same time.

WilsonLe commented 3 months ago

@ggurdin ready for review