Dismissing existing overlays leads to some weird behavior

pangeachat / client

Learn a language while texting your friends

https://krille-chan.github.io/fluffychat/

GNU Affero General Public License v3.0

1 stars 2 forks source link

Dismissing existing overlays leads to some weird behavior #371

Closed wcjord closed 3 months ago

wcjord commented 3 months ago

Currently, the default behavior of the overlay controller (overlay.dart) is to dismiss any existing popups to show its new popup (line 30 of overlay.dart). This is leading to some odd behavior. We should 1) investigate the different situations of this and 2) try doing the opposite (ie exiting this flow if there is an existing popup) and see what that UX is like.

Kelrap commented 3 months ago

@wcjord I made a PR that lets instruction popups appear without closing the toolbar. Is that what you were thinking of for this issue, or is there some other weirdness I should look into?

wcjord commented 3 months ago

@Kelrap Hey please attach PRs to issue tickets so the ticket is automatically closed when the PR is merged!

wcjord commented 3 months ago

@Kelrap let's take a look at this in action today and see what it feels like. Just come grab me