search

pangeo-data / pangeo-cloud-federation

Deployment automation for Pangeo JupyterHubs on AWS, Google, and Azure
https://pangeo.io/cloud.html
59 stars 32 forks source link

refactor branding templates for login page #189

Open scottyhq opened 5 years ago

scottyhq commented 5 years ago

Clusters on GCE are currently using a gitRepo volume to mount pangeo styling templates for custom jupyterhub login pages. We're having trouble getting this to work on AWS due to lack of write permissions at /usr/local/share/jupyterhub/, and it seems that gitRepo is deprecated according to kubernetes docs -https://kubernetes.io/docs/concepts/storage/volumes/#gitrepo.

It seems like the recommended approach would be to use initContainers under our hub: configuration, here is a nice example of that approach: https://gist.github.com/tallclair/849601a16cebeee581ef2be50c351841

But... As far as I can tell, this would require adding the initContainers configuration option under hub:: https://zero-to-jupyterhub.readthedocs.io/en/latest/reference.html#hub

So we may want to suggest this change in a new issue here: https://github.com/jupyterhub/zero-to-jupyterhub-k8s

Wanted to post here first to make sure there is not an easier approach that I'm overlooking... @jhamman, @yuvipanda

scottyhq commented 5 years ago

see also: https://github.com/pangeo-data/helm-chart/issues/73

yuvipanda commented 5 years ago

I think allowing the hub deployment to have an initcontainer specified by the user (similar to what we allow for single user) is the right thing. Would be <3 if you can open an issue - or even better a PR :)