search

pantheon-systems / circleci-orb

Use CircleCI to push code to Pantheon Dev and Multidev Environments
10 stars 18 forks source link

Executor and parameters for resource class #42

Closed omero closed 4 years ago

omero commented 4 years ago

This PR makes the resource class configurable so that CI workflows that need more memory available can get it. This option might also be helpful for teams that can decrease their size from "medium" to "small" to reduce the billing/credits impact.

stevector commented 4 years ago

@omero, is this ready for review?

stevector commented 4 years ago

I tested this branch with a regular Drupal 8 site and it worked! https://github.com/stevector/nerdologues-d8/pull/362

https://github.com/stevector/nerdologues-d8/pull/362/commits/301979ffb4c4054c6bdee1dea36da44b8945e13d

https://app.circleci.com/pipelines/github/stevector/nerdologues-d8/317/workflows/3f04932e-1eec-4d04-8259-8ebfe52fe7e7/jobs/4152/steps

I'm going to update the readme in this PR

omero commented 4 years ago

:tada: it's all we need :)

Even is not part of this PR but maybe this can work for future improvement:

Most of the parameters at executor levels are used to provide also different tags for the containers like the node orb for example at some point can be useful to allow users change between docker images if needed