search

pantheon-systems / circleci-orb

Use CircleCI to push code to Pantheon Dev and Multidev Environments
10 stars 18 forks source link

Only call terminus -n build:env:delete:ci and terminus -n build:env:delete:pr when the current build will make a new multidev #43

Closed stevector closed 4 years ago

stevector commented 4 years ago

There are currently two places in the orb where old multidev environments are deleted and they are both run on the master branch. These two steps can add a minute each to builds on the master branch.

It would use less time across all builds to only delete a multidev when the current build is going to create a new multidev. It's worth remembering that the need for automatic cleanup is more about ensuring that a build doesn't fail because the multidev limit has been reached than it is about removing old environments as soon as possible.

stevector commented 4 years ago

I discussed with @omero in a meeting. Merging now.