pantheon-systems / circleci-orb

Use CircleCI to push code to Pantheon Dev and Multidev Environments
10 stars 18 forks source link

Add option to change Master branch to Main #50

Open Farnoosh63 opened 3 years ago

Farnoosh63 commented 3 years ago

We would like to change our master branch on Github and would be great to have the option to set the default branch variable name. Thanks!

stevector commented 3 years ago

Hi @Farnoosh63, good idea! What happens when you try changing it now? Do builds on the main branch generate a ci- multidev rather than pushing to the Pantheon Dev environment?

If so, I think that the needed change might be in the underlying container where the $TERMINUS_ENV is derived: https://github.com/pantheon-systems/docker-build-tools-ci/blob/6.x/scripts/set-environment#L38 @sugaroverflow or @greg-1-anderson, what do you think?

greg-1-anderson commented 3 years ago

We could support a different default branch for Build Tools source repositories. We're not ready to do that for Pantheon repositories or upstream repositories yet, though.

sugaroverflow commented 3 years ago

+1 on supporting main as a default branch for Build Tools source repos (the project repo is already on main).

rbvea commented 3 years ago

FWIW, new repositories that are created through Github use main as the default branch now.

jasonyarrington commented 3 years ago

+1 on supporting main as a default branch for Build Tools source repos

chachasikes commented 3 years ago

master is still default branch for me (Pantheon default instance)

aliciaj commented 3 years ago

+1 on supporting main as a default branch