search

pantheon-systems / circleci-orb

Use CircleCI to push code to Pantheon Dev and Multidev Environments
10 stars 18 forks source link

Adding CIRCLE_REPOSITORY_URL as origin for full repo for 51 bug fix #52

Closed stevector closed 3 years ago

stevector commented 4 years ago

This PR is meant to address #51. As best I can tell, the way I wrote the Orb to use two repos within it's build process (a clone from Pantheon in addition to the clone from GitHub/BitBucket that comes by default in CI) had the side effect of leaving the url key empty in the build-metadata.json file.

I think I didn't notice this problem earlier because the real repos that I use the Orb with are repos that pre-date the Orb and the clean-up process called out in the #51 bug report only needs to find one environment with the url value set.

Anyway, this change seems good to merge but I'd like validation from at least one tester in #51. See this PR for an example of how to test this particular Orb revision: https://github.com/stevector/nerdologues-d8/pull/373/files

enotick commented 4 years ago

I have time to test today. I'll report later in the day on the results. Thank you!

enotick commented 3 years ago

@stevector this works for me as tested previously. Can we please merge? The dev build I have been using has expired. Thanks.

stevector commented 3 years ago

Yes, I'll cut the tag later today!