search

paoloose / urn

Split tracker / timer with GTK+ frontend. *nix alternative to LiveSplit. This is teh urn.
GNU General Public License v3.0
50 stars 5 forks source link

Split times aren't written to file #15

Closed luciferofastora closed 9 months ago

luciferofastora commented 11 months ago

When I start a new run, the attempt_count increments, showing that urn does have write access to the file. When I split a section, the "Previous Segment" time does not appear, nor does the file update. When I finish a run (split after the last segment), the timer stops, shows a Sum of best segments and Personal best with the current time, but does not update the file to reflect these times. Restarting the timer will again increment the attempt_count, while cancelling it will correctly decrement the counter.

So apparently the app can write to the file, it just doesn't write the times. Launching it from the command line doesn't yield any output.

I just pulled and installed the latest version, made sure all the dependencies were up to date etc. Searching both past issues here and on the upstream project has brought up no similar issues. Any further steps I could take to debug this?

luciferofastora commented 11 months ago

Demo.json The demo split file used. Note the incremented attempt_count despite all times being empty.

paoloose commented 11 months ago

Thanks for reporting. I'll definitely review this when I have time, probably writes are not being flushed properly.

paoloose commented 10 months ago

Hey, I completely forgot about this, but you need to hit save or save bests if you want to save your times for the current run

image

paoloose commented 10 months ago

This feature exists because you don't necessarily want to consider the current run to be your new best because you may be just testing out or skipping some splits by accident. I'll submit a documentation update to clarify this behavior.

paoloose commented 10 months ago

About the previous segment, can you please clarify what's the problem? :-)

luciferofastora commented 9 months ago

Sorry for the delayed response, my PC broke down and I couldn't actually try it until I got it fixed. The explicit saving absolutely makes sense, I just missed that File menu entirely. With that, it now saves correctly and the issue is closed as far as I'm concerned.

The "previous segment" is one of the comparisons at the bottom. It should compare the segment I last split against the PB for that segment, which obviously doesn't work if I never saved that PB.

paoloose commented 9 months ago

Nice!