search

papandreou / inter

A JavaScript locale library based on information extracted from the Unicode CLDR database
BSD 3-Clause "New" or "Revised" License
21 stars 5 forks source link

Update time package #22

Closed owcd closed 8 years ago

owcd commented 8 years ago

Building time@0.11.2 on nodejs@4.2.4 fails

time.target.mk:92: recipe for target 'Release/obj.target/time/src/time.o' failed

Looks like the time package requires an update to 0.11.4 for building fine.

papandreou commented 8 years ago

Hmm, seems like time 0.10.4 is not sufficient for it to work with 4.2 and 5: https://travis-ci.org/papandreou/inter/jobs/102569319

Any other ideas?

mwoc commented 8 years ago

The travis build says:

"Starting with io.js 3 and Node.js 4, building native extensions requires C++11-compatible compiler, which seems unavailable on this VM. Please read https://docs.travis-ci.com/user/languages/javascript-with-nodejs#Node.js-v4-(or-io.js-v3)-compiler-requirements."

So I don't think it's related to the 'time' module. Runs fine locally for me on v4.2.

mwoc commented 8 years ago

They write to update .travis.yml to make it work.

papandreou commented 8 years ago

@mwoc Ah, nice catch, trying that.

papandreou commented 8 years ago

Much better: https://travis-ci.org/papandreou/inter/builds/102615479

owcd commented 8 years ago

Thanks, works like a charm.