paris-branch / dancelor

A chancelor for Scottish country dance musicians
https://dancelor.org
0 stars 0 forks source link

Get rid of the notion of “person” #229

Closed Niols closed 1 year ago

Niols commented 1 year ago

As previously discussed, the notion of person is a bit broken and the database is not filled properly. I think it is best to remove it, and potentially to reintroduce it later under a different form. WDYT @R1kM?

Niols commented 1 year ago

I would think as a second plan that we could rename the current notion of “credit” into “person” to align on the SCDDB. We would keep the name “credit” for different data-types such as the notion of credit in MusicBrainz.

R1kM commented 1 year ago

Thinking more about it, I have mixed feelings about this. While I agree it is currently a bit of a hassle (and the db consistency isn't great), I like that finding different credits a person is involved in is currently easy. However, I won't fight strongly for it; the PR looks good, and I'm happy to see it merged.

Niols commented 1 year ago

I like that finding different credits a person is involved in is currently easy.

I agree with this in principle. But the database is very inconsistent there so it doesn't actually work that well, and I personally never use it for this reason. That's why I would think a plan more like:

would have a much better chance of success. If you're still not convinced, I'd happily discuss this more or even drop the change.

R1kM commented 1 year ago

Yeah, that sounds reasonable, and would probably help with #54 as well. Merging, thanks!