pariyatti / mobile-app

The Pariyatti mobile app
https://pariyatti.app/
GNU Affero General Public License v3.0
8 stars 11 forks source link

Auto assign groups after review is completed #144

Closed balwa closed 1 year ago

balwa commented 1 year ago

According to the documentation on codemagic,

Post-processing of App Store Connect distribution Some App Store Connect actions, like submitting the build to TestFlight beta review, distributing the build to beta groups and uploading release notes take place asynchronously in the post-processing step after the app artifact has been successfully published to App Store Connect and the main workflow has completed running in Codemagic. This avoids using the macOS build machine while we are waiting for Apple to complete processing the build and it becomes available for further actions.

https://docs.codemagic.io/flutter-publishing/publishing-to-app-store/

So the builds will be auto assigned the beta tester group after review is completed. Currently, because the group name was not correct, this async process must have been failing. And as it not part of the build process, I didn't see that in logs.

balwa commented 1 year ago

There is also another way of handling this, however it cannot be retroactively changed for the current group for which the setting is disabled:

App_Store_Connect

However, it is certainly a possibility that we create another group for developers and for that group keep the checkbox on by default at creation. That way we still would have to manually assign the builds to larger volunteer groups, but the smaller group will get the builds automatically upon completion of reviews.

deobald commented 1 year ago

However, it is certainly a possibility that we create another group for developers and for that group keep the checkbox on by default at creation. That way we still would have to manually assign the builds to larger volunteer groups, but the smaller group will get the builds automatically upon completion of reviews.

I think that our best option is to automatically release all TestFlight builds to all test users. I don't expect we'll ever have a testing pipeline (nothing fancier than "Test => Prod", at least), and the fewer manual steps, the better.