search

pariz / gountries

Gountries provides: Countries (ISO-3166-1), Country Subdivisions(ISO-3166-2), Currencies (ISO 4217), Geo Coordinates(ISO-6709) as well as translations, country borders and other stuff exposed as struct data.
MIT License
408 stars 67 forks source link

Country methods are inconsistent in receivers #10

Closed alercah closed 7 years ago

alercah commented 7 years ago

The methods for countries sometimes take pointer receivers, and sometimes take struct receivers. They should be made consistent. My preference would be to use pointers everywhere in this library, because the data structures are frequently large and shouldn't be needlessly copied.

pariz commented 7 years ago

Good point! Feel free to submit a MR, otherwise i'll to it as soon as my work situation is a less hectic.