search

pariz / gountries

Gountries provides: Countries (ISO-3166-1), Country Subdivisions(ISO-3166-2), Currencies (ISO 4217), Geo Coordinates(ISO-6709) as well as translations, country borders and other stuff exposed as struct data.
MIT License
408 stars 67 forks source link

Including translated names in NameToAlpha2 #14

Closed oschwald closed 6 years ago

oschwald commented 7 years ago

Would you be willing to accept a PR that adds translated country names to NameToAlpha2? I've run into several cases where lookups by name have failed but the spelling variant is among the translations.

pariz commented 7 years ago

Can you elaborate a bit on a case where this would be applicable?

oschwald commented 7 years ago

We receive country names from our customers and some times these are in another language (e.g., Spanish or Russian). Generally, gountries already has the name in the data files, but not in the NameToAlpha2 map, which only contains the common name and the official name.

pariz commented 6 years ago

Hi again. If this is still relevant to you, please post a PR! 👍