Closed roop closed 2 years ago
I'm closing this for three reasons:
I'll certainly take into account the considerations from this PR, so thanks!
We reverted the revert later as well -- we identified an issue that was masked by this issue and fixed that: https://github.com/eduvpn/apple/pull/484.
Attempts to resolve passepartoutvpn/passepartoutkit#34.
When we have too much data to send (like during the upload phase of a speedtest), we encounter ENOBUFS ("No buffer space available") errors like this:
To handle this scenario, this PR:
In my testing, this keeps the connection stable during the upload phase of speed tests. I don't see any noticeable reduction in upload speed.
I understand this might need a detailed review (especially commits 7f87f9f and f220ebf), so please take your time.