Section 5 comments - Githubissues

Findprefix – replaced with Rowan’s version
    -this version does not work with GUIs
    -fixed bug related to multiple suffixes with different lengths
FindSuffix
    -added function
    -doesn’t work with GUI

    -I propose we decouple both findprefix and findsuffix from the GUI

openPackageFile
    -delete it
    -Can be done in R with: openFile(system.file(".", package="PBSmodelling"))
    -I propose to add the package argument to openFile:
    i.e.: openFile( ".", package="PBSmodelling")
    -can easily be called via doAction

openExamples
    -delete it
    -exists in PBSadmbwin called: copyFiles 
    -should this stay in PBSadmbwin (my preference) or should it be moved to
PBSmodelling (if so, can you give me a different example where it would be
useful?)

openProjFiles
    -doesn't work
    -not referenced anywhere
    -very similar to: openFile( dir(pattern="^vonb\\.(r|log)$") )
    -I propose we delete this

setwdgui
    -why is there a suffix argument?
    -why is this coupled with findPrefix?
    -I propose that we remove the suffix argument

Options
    -I still think encouraging other packages to store options under
.PBSmod$.options is a foolish decision
    Packages should have their OWN private storage.
    -Please justify how this will work when two packages both use options
        a) how will settings be saved such that the two different package options
are kept separate from each other?
        b) how will you deal with two packages which both share a common key name?

    I've tested the functions, and they work as is - however the Rd files need
to be updated (and will include working examples as shown below)

    setPBSoptions - seems to work fine - sets a value to .PBSmod$.options$...
        setPBSoptions("tester", 1:10)
        > .PBSmod$.options$tester
         [1]  1  2  3  4  5  6  7  8  9 10
    getPBSoptions - works
        > getPBSoptions("tester")
         [1]  1  2  3  4  5  6  7  8  9 10
    writePBSoptions("test.txt") - works
    readPBSoptions("test.txt") - works
    promptWriteOptions - if options haven't changed, nothing is saved - nice
idea, but its buggy - so I removed it and now it always saves regardless if
options have changed

    declareGUIoptions, getGUIoptions, setGUIoptions - these work just fine -
the only problem is related to poor documentation
        The following example illustrates how to use these functions (which would
have saved me many hours of frustration)

        setPBSoptions( "foo", 999 )
        createWin("entry name=foo", astext=T)
        declareGUIoptions("foo")
        getGUIoptions() #updates entry widget with value from PBS options foo

        getPBSoptions( "foo" ) #should return 999

        #have the user change the entry widget value to 555

        getPBSoptions( "foo" ) #should still return 999

        setGUIoptions("*") #saves widget value to PBS options
        getPBSoptions( "foo" ) #now returns updated value: 555

    setPathOption, setFileOption
        -these functions have been replaced with selectDir / selectFile
        -these can be integrated with the following use of doAction:
            button text=">" func=doAction action="selectDir(usewidget=\"admpath\")"
            button text=">" func=doAction action="selectFile(usewidget=\"editor\")"
Original issue reported on code.google.com by alex_goo...@mofo.ca on 7 Sep 2009 at 8:28
pbs-software / pbs-modelling

Section 5 comments #51
