Requests from Rob Kronlund

These comments come from Rob by email dated March 8, 2010. I'm posting 
them here for the record. Note also the attached file.

Jon

***** From Rob

I have two topics: (1) setWidgetState and setWidgetColor, and (2) Item 3.2 
of the statement of work.

(1) setWidgetState and setWidgetColor.

I have re-worked testSetWidget.r in keeping with the revisions to the user 
guide.  I tried to cycle through the states (normal, readonly, disabled, 
back to normal) as applicable.

This revealed some instances of the foreground color in particular not be 
restored correctly when returning to a normal state, for example.

Also, the noeditbg, noeditfg appears to be broken for the data widget 
which causes some color mayhem as noted in the code.

This places are noted in the code using my initials and three asterisks, 
i.e., ARK ***

Considering the number of dynamic controls we added, these few small 
problems are to be expected.

Note that the testSetWidget.r code lets you assign the color choices as a 
global, so if you don't like mine you can change them!

(2) Item 3.2 of the specifications.

This item focused on justification of label widgets, comparing the 
behavior when width was set (text gets centered and is not affected by 
sticky and when width is not set (text responds to sticky).

I had suggested that sticky should have an effect regardless of whether 
width was set.

In the case where width is set then the string must get padded equally on 
each side to fill to the specified width.

For all I know this may have been a design feature of PBSmodelling.  
However, I would have thought the sticky parameter would control the 
padding on the left (W), right (E) or centered if not specified….

Your views please so we can move along on this item.

Finally, I will be giving the user guide a quick read to make sure various 
changes suggested by Rowan got in - Jon has I believe spent some time 
adding text which is now posted on the Google site.
Original issue reported on code.google.com by schnu...@shaw.ca on 11 Mar 2010 at 3:54
Attachments:
testSetWidget.r
pbs-software / pbs-modelling

Requests from Rob Kronlund #64
