search

pbs-software / pbs-modelling

R package PBSmodelling - GUI tools made easy: interact with models and explore data
2 stars 1 forks source link

Two bugs in history widget #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There remain two bugs in the history widget verified by RH & JTS.

1. When the history file contains a 'text' widget, the Sort button
   does not sort the slides.

2. The Import and Export buttons are still using deprecated 
   functions 'promptOpenfile' and 'promptSavefile'. 
   These functions need to be replaced with the function 'selectFile'.

Original issue reported on code.google.com by rowan.ha...@dfo-mpo.gc.ca on 14 Jan 2011 at 11:37

GoogleCodeExporter commented 9 years ago 
I'm not absolutely sure that the problem relates to text widgets. You can find 
an important example in runExamples() by selecting "FishRes" in the Simulation 
column. Notice that the GUI has both a history widget and a text box (named 
"msg"). If you click the sort function in the history widget, you get the 
anticipated spreadsheet for your new style, although the "msg" field contains 
integers, not the actual text.

If you attempt to sort the history records and save them, you get the message:

Error in jumpHistory(hisname, 1) : 
  History "window.default" not intialized - see initHistory

Also, the history widget does not include the new sort order.

This comment applies to PBS Modelling 2.62.221 and R 2.12.1.

Original comment by schnu...@shaw.ca on 15 Jan 2011 at 1:59

GoogleCodeExporter commented 9 years ago 
1) replicate with

library(PBSmodelling); createWin( c("text foo edit=T", "entry mode=character 
name=ent", "history"), TRUE)

Occurs for all textbased modes (perhaps a levels issue?)

The sort window still displays and can resort slides (just the info displayed 
on sort table is meaningless)

Original comment by alex_goo...@mofo.ca on 17 Jan 2011 at 3:15

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
revision 222 fixes issue number 1 - levels were to blame.
also added string trimming to trim strings over 15 characters long - not sure 
if 15 characters is a good choice or not.

Original comment by alex_goo...@mofo.ca on 17 Jan 2011 at 4:37

GoogleCodeExporter commented 9 years ago 
both issues fixed in r223

Original comment by alex_goo...@mofo.ca on 17 Jan 2011 at 5:14

GoogleCodeExporter commented 9 years ago

Original comment by alex_goo...@mofo.ca on 17 Jan 2011 at 5:14