Closed ZLLentz closed 1 year ago
This is now... maybe done? It feels pretty done.
The repo as-is is the live lpmps
screen. It's also the live kpmps
screen but the kfe arbiter IOC is offline (and likely not updated to include the beamclass stuff even if it came up).
There's a disconnected PV at the top for the NC vs SC mode from ACR. I don't know if the PV I'm using is wrong or if there's some gateway issue. The screen uses this value to hide/show things dynamically, but you can also manually try this feature using the combobox override at the top that starts off at "Auto". With the PV disconnected, "Auto" is the same as "show both NC and SC". Otherwise, with the PV connected, it should automatically show NC only or SC only as appropriate.
The line beam parameters tab always shows both sets of controls because you might want to set the non-active side to zero.
Oh you're totally right, the grafana panel is SOL right now. I'll add an issue for that (it's been in the back of my mind/ignored since a previous iteration was crashing the GUI)
I'll opt to just add a new screenshot and more context to https://github.com/pcdshub/pmps-ui/issues/75
One more thing to add before merging: I guessed wrong and the mode pv (NC vs SC from ACR) is an enum, not a string. So I need to use the enum str etc. etc. to make my Auto mode work.
Ok let's close this here and do any follow-up work in another PR as needed
This is deployed as-is for
lpmps
andkpmps
.kpmps
isn't quite ready yet for the new PVs.Some of the code is a little messy, sorry about that.
Big ideas:
Original to-do list:
And maybe more?