pcdshub / pmps-ui

User interfaces and diagnostics for PMPS
Other
0 stars 9 forks source link

ENH: transmission override ui elements #92

Closed ZLLentz closed 1 year ago

ZLLentz commented 1 year ago

This PR is a companion to https://github.com/pcdshub/lcls-plc-kfe-arbiter/pull/20 In that PR, Maggie adds code and PVs for a user "Judgement Factor" that essentially acts as a PMPS transmission override.

This PR uses those PVs to:

I feel pretty good about most of it. The transmission read/write feels somewhat janky to me. I cannot (should not) make the UI write to PVs unprompted, so I think this is the best I can do in the python layer without creating horrors, but it still feels a bit off.

Updated pre-emptive requests tab (there are now 2 columns for transmission): image

Updated line beam parameters tab (added section headers, new section at the bottom, added tooltips): image

ZLLentz commented 1 year ago

First: adding to the line beam parameters tab image

ZLLentz commented 1 year ago

Second: include in the table (hard to see if this is working right without changing the PVs) image

ZLLentz commented 1 year ago

Currently I'm trying to figure out if/how to handle the tranmission select that we want to modulate via the judgement factor I'm also reconsidering the placement of the new section: maybe it should be at the start or at the end? It's kind of bad for it to be in the middle of the rest because it disconnects the original "apply" button from the transmission section

ZLLentz commented 1 year ago

Here's a substantial redesign of the line beam parameters tab, which I think is more logical: image

ZLLentz commented 1 year ago

I'm going to self-review and clean up the code as appropriate Then, I'm going to ask for a few reviews The intention is to test this during the PAMM

ZLLentz commented 1 year ago

New tab is needed because having two "apply" buttons on the same page is extremely confusing

ZLLentz commented 1 year ago

I think we've landed in a good spot. I've also added a few usage notes and hidden the new features on the LFE screen.

Some final screenshots: KFE preemptive requests tab:

image

KFE line beam parameters tab:

image

KFE transmission override tab:

image

LFE preemptive requests tab (note the differences between this and the others):

image

ZLLentz commented 1 year ago

I think this is ready for any final thoughts and review. I need to get Maggie's opinion for sure (tomorrow, she's out this afternoon) and deploy this in a way that TMO + XBD can give feedback prior to their Thursday beamtime.

ZLLentz commented 1 year ago

I think I'm going to merge this as soon as I'm ready to return here for style/ci cleanup, pending any other comments that come in prior to me getting back here

I'd like to do the style/ci in a separate PR to keep them separate from the functional/design changes

ZLLentz commented 1 year ago

Maggie said this was good offline, so I'm going to merge and deploy as-is while we have the cover of the POMM. I still need to revisit for some cleanup.