fix(PLC:KFE:VAC:KO:FFO:05): extended the ffo_end for the KFE VAC fast faults to catch a 5th fault because we had a collision with the fault numbers on the PLC end

pcdshub / pmps-ui

User interfaces and diagnostics for PMPS

Other

0 stars 8 forks source link

fix(PLC:KFE:VAC:KO:FFO:05): extended the ffo_end for the KFE VAC fast faults to catch a 5th fault because we had a collision with the fault numbers on the PLC end #93

Closed joshc-slac closed 11 months ago

joshc-slac commented 11 months ago

Description & Motivation

PR #36 for lcls-plc-kfe-vac addresses a collision in the fast fault integer enumeration for the KFE vacuum system. This PR extends the ffo_end field for the PLC:KFE:VAC:K0: fast fault to accept that incremented integer.

Linked PRs

https://github.com/pcdshub/lcls-plc-kfe-vac/pull/36

Testing

[ ] Close VFS-1 and see if we see it in PMPS Diag

ZLLentz commented 11 months ago

The fix looks correct to me
Ignore the CI here- there really isn't any, I need to clean up this repo
The PLC side doesn't seem to be done: output 5 is still missing. I assume this is waiting for some sort of PLC/IOC deployment?

ZLLentz commented 11 months ago

@joshc-slac I noticed that the "as-deployed" folder has a bunch of other miscellaneous config changes. Are you OK with me merging this as-is so I can bring all of these updates together? Or is there other testing that is still needed, and I should merge in the rest of the changes without this one?

joshc-slac commented 11 months ago

I am okay with this; @ghalym I will check that my build settings were correct on this PR and we can test the deployment prior to merge tomorrow?